Closed
Bug 115532
Opened 23 years ago
Closed 22 years ago
[FIX]background images not saving for 'Save Page as web page complete'
Categories
(SeaMonkey :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.1beta
People
(Reporter: benm, Assigned: bzbarsky)
References
()
Details
(Keywords: helpwanted)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
adamlock
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
background images are not being saved, and are not recognised in source for the
save as web page complete.
<td height="70" background="../image/new/tile.jpg">
<img border="0"
src="Build%20Comments%20-%20MozillaZine%21%20Your%20Source%20for%20Mozilla%20News%20and%20Advocacy_files/title.gif"
width="180" height="70" align="left" alt="mozillaZine">
"Build%20Comments%20-%20MozillaZine%21%20Your%20Source%20for%20Mozilla%20News%20and%20Advocacy_files"
is the directory created for all images to be saved into, this dosent happen for
background images.
Comment 1•23 years ago
|
||
see bug 11632 comment 85.. dont know if this was suppose to be added in.
Assignee | ||
Comment 2•23 years ago
|
||
Duplicate of "table/cell backgrounds not saved with save complete"
*** This bug has been marked as a duplicate of 115107 ***
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Also note there is no such attribute as "background" on the TD tag. Perhaps
Mozilla is honouring this in quirks mode, but my persistence code isn't at the
moment.
Assignee | ||
Comment 4•23 years ago
|
||
While there is no background attr in HTML4, we _do_ support it and it's widely
used... I think we should persist these backgrounds.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 5•23 years ago
|
||
taking bug. Adam, let me know if you feel we really should not do this sometime
in the next few days, ok?
Assignee: asa → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Priority: -- → P3
Target Milestone: --- → mozilla1.1
If it's a widely supported quirk then yes I agree we should add support for it.
The standard nsIDOMHTMLTable* interfaces do not have a background attribute so
the patch would have to pull it out using the nsIDOMElement/nsIDOMNode interfaces.
Assignee | ||
Comment 7•23 years ago
|
||
Yeah... backgrounds on table/tr/td are fairly common, unfortunately.
As the target suggests, I'm not getting to this any time soon, so feel free to
take if you're going to have time before 1.0 for it. :)
Keywords: helpwanted
Assignee | ||
Comment 8•22 years ago
|
||
1.1alpha is frozen. Unsetting milestone and will retriage in a few days when I
can make a realistic assessment of the situation.
Target Milestone: mozilla1.1alpha → ---
Assignee | ||
Comment 9•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Priority: P3 → P2
Summary: background images not saving for 'Save Page as web page complete' → [FIX]background images not saving for 'Save Page as web page complete'
Target Milestone: --- → mozilla1.1beta
Assignee | ||
Comment 10•22 years ago
|
||
Oh, the irrelevant stuff in there is compile warning fixes.
Comment 11•22 years ago
|
||
Comment on attachment 88566 [details] [diff] [review]
Proposed fix
You're missing the code to
nsWebBrowserPersist::CloneNodeWithFixedUpURIAttributes to fix up the background
attribute with the new file location.
Without it, the background will be saved but the document will still point to
the original one.
Attachment #88566 -
Flags: needs-work+
Assignee | ||
Comment 12•22 years ago
|
||
Attachment #88566 -
Attachment is obsolete: true
Comment 13•22 years ago
|
||
Comment on attachment 88622 [details] [diff] [review]
Doh. That makes sense...
r=adamlock
Attachment #88622 -
Flags: review+
Comment 14•22 years ago
|
||
Comment on attachment 88622 [details] [diff] [review]
Doh. That makes sense...
sr=jst
Attachment #88622 -
Flags: superreview+
Assignee | ||
Comment 15•22 years ago
|
||
fixed on trunk
Status: NEW → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•