Closed
Bug 1155515
Opened 10 years ago
Closed 10 years ago
Disable Reading List and RL Sync on all channels
Categories
(Firefox Graveyard :: Reading List, defect)
Firefox Graveyard
Reading List
Tracking
(firefox38-, firefox39 fixed, firefox40 fixed)
VERIFIED
FIXED
Firefox 40
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
(deleted),
patch
|
markh
:
review+
Dolske
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
For the near term (and especially 38.1), we will be focusing on Pocket integration instead of the Reading List/Sync work we've been doing. Until we understand how "Reading List" and Pocket may coexist, we will disable Reading List and the new Reading List Sync service.
[Note that Android will, for now, continue to support the Reading List that they've shipped with for a long time. Although the newly-written Sync code for it will be disabled, since Desktop and iOS won't be using it.]
See also bug 1155191, where we disabled this on 38.0.
Reader View is largely unaffected by this change.
Users on pre-release channels (Nightly/DevEdition/Beta) who have already added things to their Reading List will no longer have access to them. There will be no migration to Pocket -- sorry. If affected users need to get back to their Reading List items, I'd suggest they download an older build, go through their list, and convert items to bookmarks (which will sync across devices with Firefox Sync). Or wait until our Pocket integration is functional, and s/bookmarks/Pocket/.
Comment 1•10 years ago
|
||
Tracked for 38 for obvious reasons.
status-firefox38:
--- → affected
tracking-firefox38:
--- → +
Tracking for 39+ as well.
status-firefox39:
--- → affected
status-firefox40:
--- → affected
tracking-firefox39:
--- → +
tracking-firefox40:
--- → +
Assignee | ||
Comment 3•10 years ago
|
||
Unlike bug 1155191, this just softly flips the default prefs. This will land on Nightly and Aurora (40+39).
I disabled it harder in the other bug for 38.* because it seems like there's significant short-term risk of confusion around this feature, and I wanted to avoid having Release users think this is a new-and-almost-ready feature based on something they read in a random blog post. That should be less of a problem when 39 makes it to release, and by then we'll hopefully have a better understanding of the future plans, if any, for Reading List.
Assignee: nobody → dolske
Attachment #8594427 -
Flags: review?(mhammond)
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> Tracked for 38 for obvious reasons.
Actually bug 1155191 is disabling this for 38.0 and 38.1 (same thing, since we haven't branched yet). So I don't think we need to track _this_ bug for 38?
Flags: needinfo?(sledru)
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #3)
> Created attachment 8594427 [details] [diff] [review]
> Patch v.1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ecaa8cd2d96
Updated•10 years ago
|
Attachment #8594427 -
Flags: review?(mhammond) → review+
Updated•10 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Comment 8•10 years ago
|
||
(Added a pref flip to browser/components/readinglist/test/xpcshell/test_scheduler.js, glad I did that Try run!)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8594427 [details] [diff] [review]
Patch v.1
[Triage Comment]
(As noted above, bug 1155191 landed a stricter version of this on beta, so no beta approval needed here.)
Attachment #8594427 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 10•10 years ago
|
||
status-firefox38:
affected → ---
Comment 11•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•10 years ago
|
Iteration: --- → 40.2 - 27 Apr
Untracking; looks like this is fixed and has had no issues for the last week.
tracking-firefox39:
+ → ---
tracking-firefox40:
+ → ---
Comment 13•10 years ago
|
||
The patch pushed for this bug was also verified through the testing conducted on Bug 1155191. Closing.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•