Closed
Bug 1156052
Opened 10 years ago
Closed 10 years ago
Add push information to about:serviceworkers
Categories
(Core :: DOM: Notifications, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
Screenshot 2015-04-20 12.43.05.png
No description provided.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers
Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/content/aboutServiceWorkers.js
@@ +12,5 @@
> +XPCOMUtils.defineLazyServiceGetter(
> + this,
> + "PushNotificationService",
> + "@mozilla.org/push/NotificationService;1",
> + "nsIPushNotificationService"
does it exist? I don't find it in m-c.
Can you point me to where this is implemented?
Attachment #8594438 -
Flags: review?(amarchesini)
|
|
||
Comment 3•10 years ago
|
||
I would like to see if we can show more than just a JSON.stringify but I didn't find where nsIPushNotificationService is implemented.
Flags: needinfo?(dougt)
|
Assignee | |
Comment 4•10 years ago
|
||
nsIPush* hasn't landed yet. See bug 1150683.
Depends on: 1150683
Flags: needinfo?(dougt)
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8594438 -
Flags: review?(amarchesini)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers
Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm, but file a bug to make a better UI.
Attachment #8594438 -
Flags: review?(amarchesini) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•