Closed
Bug 1156088
Opened 10 years ago
Closed 10 years ago
Doorhangers display useless "Learn more..." link when using the Modern theme
Categories
(SeaMonkey :: Themes, defect)
Tracking
(seamonkey2.34 affected, seamonkey2.35 affected, seamonkey2.36 fixed, seamonkey2.37 fixed)
RESOLVED
FIXED
seamonkey2.37
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
philip.chee
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
philip.chee
:
approval-comm-release-
|
Details | Diff | Splinter Review |
When bug 967349 added the "Learn more..." link to doorhangers they had the bright idea of controlling the visibility of the link in skin rather than content.
Not only does this mean that the rule gets triplicated in Firefox but it also means that we need to port it to Modern.
|
Assignee | |
Comment 1•10 years ago
|
||
The extra margin doesn't seem to buy us anything so I ignored it.
|
||
Updated•10 years ago
|
Attachment #8594507 -
Flags: review?(philip.chee) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.37
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8594507 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 967349
User impact if declined: Useless UI
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #8594507 -
Flags: approval-comm-beta?
Attachment #8594507 -
Flags: approval-comm-aurora?
Attachment #8594507 -
Flags: approval-comm-beta?
Attachment #8594507 -
Flags: approval-comm-beta+
Attachment #8594507 -
Flags: approval-comm-aurora?
Attachment #8594507 -
Flags: approval-comm-aurora+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8594507 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): 967349
User impact if declined: Useless UI
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #8594507 -
Flags: approval-comm-release?
|
|
||
Updated•9 years ago
|
Blocks: SM2.35-Uplift
|
|
||
Updated•8 years ago
|
Attachment #8594507 -
Flags: approval-comm-release? → approval-comm-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•