Markus Stange [:mstange] Assignee
	Description • 9 years ago

At the moment we're not letting APZ know about mouse move events so it doesn't reset the wheel transaction properly.

	Markus Stange [:mstange] Assignee
	Comment 1 • 9 years ago

There are more places I could convert, but I'm too lazy to do it at the moment.

	David Anderson [:dvander] - inactive, e-mail if emergency
	Comment 2 • 9 years ago

Comment on attachment 8595549 [details] [diff] [review]
patch

Review of attachment 8595549 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment fixed

::: widget/cocoa/nsChildView.mm
@@ +4492,5 @@
>    else
>      geckoEvent.button = WidgetMouseEvent::eLeftButton;
>  
>    // This might destroy our widget (and null out mGeckoChild).
> +  bool defaultPrevented = mGeckoChild->DispatchInputEvent(&geckoEvent);

here, and...

@@ +5452,5 @@
>  
>    WidgetMouseEvent geckoEvent(true, NS_MOUSE_ACTIVATE, mGeckoChild,
>                                WidgetMouseEvent::eReal);
>    [self convertCocoaMouseEvent:aEvent toGeckoEvent:&geckoEvent];
> +  return !mGeckoChild->DispatchInputEvent(&geckoEvent);

Here, nsBaseWidget::DispatchInputEvent returns nsEventStatus not boolean. So you need a ConvertStatus unless there's a wrapper I missed.

	Markus Stange [:mstange] Assignee
	Comment 3 • 9 years ago

Huh, don't know how I missed that. Thanks!

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/80518fa5c0d6

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 5 • 9 years ago

Blassey mentioned on IRC that he enabled APZ on mac and was intermittently seeing the tab list scroll while the mouse pointer was in the content area and he scrolled with the trackpad. I suspect this patch might fix the behaviour by more properly untransforming events to take into account the async transform. I hope.

	Markus Stange [:mstange] Assignee
	Comment 6 • 9 years ago

Yes, this patch should fix that.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/80518fa5c0d6