I'm going to do this also for any other part of the tree. Of course I'm not doing it manually.

I guess we need a JS peer for this patch.

Testing if these patches break something: https://treeherder.mozilla.org/#/jobs?repo=try&revision=714c52566be0

Comment on attachment 8595291 [details] [diff] [review] patch 7 - JS Review of attachment 8595291 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. I don't know what all of these were, but it's kind of interesting seeing the code evolution reflected in these.

Just so you know, I expect that landing this patch will severely break people's ability to do non-unified builds. I think there are some people who care about those builds... Maybe dholbert knows? Anyways, I'm fine with landing this. Please make sure other people are as well.

I don't know who (if anyone) depends on non-unified builds. IIRC they're officially unsupported, and probably don't compile at the moment. And if these patches do what I think they do*, I'm fine with taking them as well. *(From a quick skim, I think you're just removing forward-decls _in cases where the declared type isn't used at all in that file_, correct? One alternate thing that I thought you might've been doing was: removing forward-declares that end up being redundant as a result of unified builds -- e.g. if A.cpp and B.cpp both forward-declare & use something, you might be able to remove the forward-declare from B.cpp (or from some headers used only in B.cpp) and still be fine building. That would be bad, though, because it'd add a fragile dependency, which would be exposed once we added new source files between A.cpp and B.cpp & reshuffled the unified groupings. So, I'd object to cleanup of that sort; but I don't think that's what you're doing here.)

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/73917a03e734 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/29bf41172acd remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7617f4ffb314 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/60a2001adf9a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d47f66ce3822 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e1d3ea76296 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f79844c376f

https://hg.mozilla.org/mozilla-central/rev/73917a03e734 https://hg.mozilla.org/mozilla-central/rev/29bf41172acd https://hg.mozilla.org/mozilla-central/rev/7617f4ffb314 https://hg.mozilla.org/mozilla-central/rev/60a2001adf9a https://hg.mozilla.org/mozilla-central/rev/d47f66ce3822 https://hg.mozilla.org/mozilla-central/rev/9e1d3ea76296 https://hg.mozilla.org/mozilla-central/rev/1f79844c376f