Closed Bug 1157143 Opened 10 years ago Closed 10 years ago

in-content/common.css: No indication when a menuitem is disabled

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 2 obsolete files)

Screenshot 2015-04-21 15.29.31.png
(deleted), image/png
Details
Bug1157143.patch v3
(deleted), patch
dao
: review+
Details | Diff | Splinter Review
Attached image Screenshot 2015-04-21 15.29.31.png (deleted) —
From bug 989469 comment 148: Heycam spotted another UI problem in the current patch, the "Ask to activate" option for Open H264 is disabled but it appears enabled in the current patch.
Attached patch Bug1157143.patch (obsolete) (deleted) — — Splinter Review
The disabled menu/menuitems have now a opacity of 0.5 and no highlight on _moz-menuactive.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8595852 - Flags: review?(jaws)
Blocks: 989469
Comment on attachment 8595852 [details] [diff] [review] Bug1157143.patch Review of attachment 8595852 [details] [diff] [review]: ----------------------------------------------------------------- Jared is overloaded, dao, can you take a quick look here?
Attachment #8595852 - Flags: review?(jaws) → review?(dao)
Comment on attachment 8595852 [details] [diff] [review] Bug1157143.patch Reducing the opacity might impair text rendering quality, i.e. disable sub-pixel AA. Adjusting the text color seems preferable. Also, why did you set the background-color to transparent? You already changed the other selectors setting a background-color to exclude disabled items.
Attachment #8595852 - Flags: review?(dao) → review-
Attached patch Bug1157143.patch v2 (obsolete) (deleted) — — Splinter Review
(In reply to Dão Gottwald [:dao] from comment #3) > Comment on attachment 8595852 [details] [diff] [review] > Bug1157143.patch > > Reducing the opacity might impair text rendering quality, i.e. disable > sub-pixel AA. Adjusting the text color seems preferable. Using now the Chameleon color #c1c1c1. > Also, why did you set the background-color to transparent? You already > changed the other selectors setting a background-color to exclude disabled > items. This is to override global/menu.css rules like: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/menu.css#200 Linux and OS X do also have such definitions. I added a comment in code.
Attachment #8595852 - Attachment is obsolete: true
Attachment #8600045 - Flags: review?(dao)
(In reply to Richard Marti (:Paenglab) from comment #4) > Created attachment 8600045 [details] [diff] [review] > Bug1157143.patch v2 > > (In reply to Dão Gottwald [:dao] from comment #3) > > Comment on attachment 8595852 [details] [diff] [review] > > Bug1157143.patch > > > > Reducing the opacity might impair text rendering quality, i.e. disable > > sub-pixel AA. Adjusting the text color seems preferable. > > Using now the Chameleon color #c1c1c1. I believe #333 with a 50% opacity against a white background would be #999...
Attached patch Bug1157143.patch v3 (deleted) — — Splinter Review
Using #999 instead of #c1c1c1
Attachment #8600045 - Attachment is obsolete: true
Attachment #8600045 - Flags: review?(dao)
Attachment #8600061 - Flags: review?(dao)
Attachment #8600061 - Flags: review?(dao) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b56267ff0882
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: