[1.Description]: [110n][v2.2][Camera]Russian:Enter camera portrait mode.Open Options,enter Self-timer options,the string "Self-timer" overlaps with the "Off" string in portrait mode. Attachment:2015-04-22-14-23-50.png [2.Testing Steps]: 1.Set system language to Russian 2.Launch Camera 3.Tap Options icon->Tap Self-timer [3.Expected Result]: 3.The string "Self-timer" overlaps with the "Off" string in portrait mode. [4.Actual Result]: 3.The string "Self-timer" does not overlap with the "Off" string in portrait mode. [5.Reproduction build]: Device: Flame 2.2 user (affected) Build ID 20150421002501 Gaia Revision 828dd03a0e3b140d74b2e49355197df4d91d9227 Gaia Date 2015-04-20 18:28:39 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/36f72a3efb9b Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150421.042925 Firmware Date Tue Apr 21 04:29:36 EDT 2015 Bootloader L1TC000118D0 Device Flame 2.1 user build (Unaffected) Build ID 20150421001205 Gaia Revision bbe983b4e8bebfec26b3726b79568a22d667223c Gaia Date 2015-04-09 13:52:48 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b85d4f4a6d61 Gecko Version 34.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150421.040717 Firmware Date Tue Apr 21 04:07:27 EDT 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test

Not an l10n issue. This was fixed in 2.1. Affects shipping locales and is a regression: nominating for general triage to decide if we should block on this case or not

Asking for UX help on this! thanks

ni david.

Removing UX flag since this is a straight regression, and should look as it did prior.

Diego: This is a blocker. Can you take it or find someone to take it, please? Wilson: since this is in the menu code, I would have asked you to take it, but I assume you're probably pretty busy getting ready for the web components meeting tomorrow. Delphine: I don't know what the word "Russian" looks like in Cyrillic, so I don't actually know how to select that locale on my phone. I see 3 or 4 cyrillic choices in the list of languages. Could you help out with that? Also: this really looks to me like a mis-configured locale file. Could you point us to the repo that holds the Russian localizations so we can check that?

David: Google translate or any other kind of dictionary? :) It's Русский under settings. For the repo, Russian on 2.2 is currently here: https://hg.mozilla.org/gaia-l10n/ru/ thanks!

I've shortened this string for Russian l10n: http://hg.mozilla.org/gaia-l10n/ru/rev/c98050727e50

Thank you Alexander. I think that should resolve this as a blocker. Diego: do you think it is still worth patching the camera app so that it doesn't word-wrap the menu headers like that? Presumably this too-long string should have appeared on a single line with an ellipsis, right?

Gaia header (https://github.com/gaia-components/gaia-header/blob/master/gaia-header.js#L174) address these sort of issues by using font-fit logic and then fallback to ellipsis. This bug is not exclusive to the Self-timer text. In other parts of gaia very long strings might cause other visual glitches. Instead of hacking a fix for this particular case it would be easier to make this specific Russian string shorter if possible and wait for the proper fix once we fully adopt gaia components. What do you think?

I'm going to hack something quick and you can decide if you want to merge it

Comment on attachment 8598778 [details] [gaia] dmarcos:bug1157169 > mozilla-b2g:v2.2 This prevents line wrapping and falls back to ellipsis when the settings header is too long.

I just verified that https://github.com/mozilla-b2g/gaia/pull/29773 works properly in RTL mode

Comment on attachment 8598778 [details] [gaia] dmarcos:bug1157169 > mozilla-b2g:v2.2 I think this change is worth making. See my comment on github, though: could you get the same effect with a simpler change to setting_title instead of setting_header? Also, please land the patch on master, not directly on 2.2. I'm going to clear the 2.2+ flag since the specific long Russian string has been changed, but I'd request uplift to 2.2.

I think we should uplift Diego's patch, but because the Russian localization has been changed, it is no longer a blocking bug if we don't uplift it.

Comment on attachment 8598905 [details] [gaia] dmarcos:bug1157169master > mozilla-b2g:master Carrying over r+

Landed on master: https://github.com/mozilla-b2g/gaia/commit/13e817eaaf232321b690e8437209d88e6773feca

Comment on attachment 8598905 [details] [gaia] dmarcos:bug1157169master > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): CSS rules don't prevent line wrapping if the options header text is longer than the container [User impact] if declined: Long strings in the settings header will overlap the options making the menu difficult to read and confusing for the user [Testing completed]: The bug was discovered on the Russian localization where the string of the settings title is longer than the rest. After applying the fix the Russian string doesn't wrap anymore and an ellipsis is displayed when the text doesn't fit the container. A screenshot is attached to this bug. [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: None

Comment on attachment 8598905 [details] [gaia] dmarcos:bug1157169master > mozilla-b2g:master Thanks Diego. Its a one-line patch and I support uplifting it, but I can't make that decision, so re-directing the approval request to Bhavna.

Comment on attachment 8598905 [details] [gaia] dmarcos:bug1157169master > mozilla-b2g:master low risk, css change, a+.

v2.2: https://github.com/mozilla-b2g/gaia/commit/9b0a266749d0777719a38546b1ee65c24f871e94

Hi Boon, Could you help verify this bug? thanks.

This issue has been successfully verified on flame3.0user & flame2.2user. Reproduce rate:0/3 See attachment: Verify1_Pass_2.2 User.png Verify1_Pass_3.0 User.png Device: Flame 2.2 user build (Verified) Build ID 20150505002501 Gaia Revision 772a9491909abd02dc67278dd453746e2dd358a8 Gaia Date 2015-05-05 02:02:24 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2df83538ae20 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150505.041457 Firmware Date Tue May 5 04:15:08 EDT 2015 Bootloader L1TC000118D0 Device: Flame 3.0 user build (Verified) Build ID 20150504160201 Gaia Revision 70077825aab2c7a79611befb40a5fe7e610d5443 Gaia Date 2015-05-04 18:09:33 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/102d0e9aa9e1 Gecko Version 40.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150504.193019 Firmware Date Mon May 4 19:30:30 EDT 2015 Bootloader L1TC000118D0