Closed Bug 1157502 Opened 10 years ago Closed 9 years ago

JSM files don't get syntax highlighting

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MattN, Assigned: gps)

References

Details

(Whiteboard: [fixed in core])

My understanding is that ReviewBoard uses Pygments and decides on the Lexer using only the file extension but ".jsm" isn't in the list of extensions for JavaScript. Some options: * try to get ".jsm" added to Pygments * Get https://code.google.com/p/reviewboard/issues/detail?id=2104 fixed in RB and use that downstream * Fix this ourselves for our installation.
This landed upstream. We'll have to wait for the next Pygments release then deploy it.
Whiteboard: [fixed in core]
I suspect that the syntax highlighting snafus on hg.m.o are the same problem? Is this bug good enough, or should we clone it?
(In reply to Gregory Szorc [:gps] from comment #2) > This landed upstream. We'll have to wait for the next Pygments release then > deploy it. Can we please make our own pre-release build and deploy it? It could be months before a new release as it's already been 10 months since the last one.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Flags: needinfo?(gps)
(In reply to Matthew N. [:MattN] from comment #4) > Can we please make our own pre-release build and deploy it? It could be > months before a new release as it's already been 10 months since the last > one. Yes.
Flags: needinfo?(gps)
hg.mozilla.org and reviewboard.mozilla.org now treats .jsm files as JavaScript. reviewboard-hg.mozilla.org still doesn't because we're installing Pygments from a Mercurial repo and `hg` on this machine has special requirements due to being a special review server and is thus disallowing the repo to be created without a "repoid" config option (needed for review repos). This repoid restriction is kinda silly. But I don't think many people go to reviewboard-hg.mozilla.org, so meh.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thank you!
Blocks: 1227715
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.