Closed
Bug 1158232
Opened 10 years ago
Closed 10 years ago
[Customizer] Replace 'Events' tab with 'Script' tab to allow direct access to edit the generated add-on
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)
Firefox OS Graveyard
Gaia::Customizer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
In order to be as flexible as possible for "V1", we should allow the user to directly edit the generated add-on script.
Assignee | ||
Comment 1•10 years ago
|
||
Bulk update to set the correct component and whiteboard.
Component: Gaia → Gaia::Customizer
Whiteboard: [spark]
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8598817 -
Flags: review?(drs)
Assignee | ||
Updated•10 years ago
|
Comment 3•10 years ago
|
||
Comment on attachment 8598817 [details]
pull-request (master)
I left a couple of comments, one of which requires some discussion, so I'm not changing the review flag yet. But this generally looks good.
Comment 4•10 years ago
|
||
Comment on attachment 8598817 [details]
pull-request (master)
Looks good. Two points:
* I left a comment about filing a bug for the CSS variable workaround, and including that number in the comment.
* Please file a followup for doing some very simple validation on source passed into the "Script" section.
Attachment #8598817 -
Flags: review?(drs) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed on master:
https://github.com/fxos/customizer/commit/44f6c9709a09774ff9831e92a90fda62092ec361
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•10 years ago
|
||
Follow-up for adding JavaScript code validation: Bug 1159454
You need to log in
before you can comment on or make changes to this bug.
Description
•