Closed Bug 1158257 Opened 10 years ago Closed 10 years ago

Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf
(deleted), patch
fitzgen
: review+
Details | Diff | Splinter Review
Right now only the shell calls JS::dbg::SetDebuggerMallocSizeOf, meaning that we can't use JS::ubi::Node::size meaningfully outside of shell builds. I think CycleCollectedJSRuntime is the right place.
Comment on attachment 8597416 [details] [diff] [review] Gecko should always provide SpiderMonkey with a debuggerMallocSizeOf Review of attachment 8597416 [details] [diff] [review]: ----------------------------------------------------------------- Yay, tests! ::: js/src/vm/DebuggerMemory.cpp @@ +337,5 @@ > /* Debugger.Memory.prototype.takeCensus */ > > void > JS::dbg::SetDebuggerMallocSizeOf(JSRuntime* rt, mozilla::MallocSizeOf mallocSizeOf) { > + printf("FITZGEN: inside JS::dbg::SetDebuggerMallocSizeOf\n"); remove this
Attachment #8597416 - Flags: review?(continuation) → review+
(In reply to Andrew McCreight [:mccr8] from comment #2) > @@ +337,5 @@ > > /* Debugger.Memory.prototype.takeCensus */ > > > > void > > JS::dbg::SetDebuggerMallocSizeOf(JSRuntime* rt, mozilla::MallocSizeOf mallocSizeOf) { > > + printf("FITZGEN: inside JS::dbg::SetDebuggerMallocSizeOf\n"); > > remove this >_< sorry
https://hg.mozilla.org/mozilla-central/rev/600207b62020
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: