WebIDE should record the version of the target we connect to. This could be used to evaluate how far back we should support compatibility.

/r/8491 - Bug 1159043 - Record WebIDE runtime info in Telemetry. r=ochameau Pull down this commit: hg pull -r b402555ee3b2c96daf53c6ac8a48daabf75bfd8d https://reviewboard-hg.mozilla.org/gecko/

Going to send to try, but try is closed for now.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f5e6243187

Comment on attachment 8604169 [details] MozReview Request: bz://1159043/jryans https://reviewboard.mozilla.org/r/8489/#review7163 ::: toolkit/components/telemetry/Histograms.json:6565 (Diff revision 1) > + "kind": "boolean", boolean? ::: browser/devtools/webide/modules/app-manager.js:513 (Diff revision 1) > + let info = `${d.processor}|${d.os}|${d.platformversion}|${d.apptype}|${d.version}`; Are you sure you want such a complex key? I don't know how is displayed this data but it may introduce a lot of diversity in the possible key values.

(In reply to Alexandre Poirot [:ochameau] from comment #4) > Comment on attachment 8604169 [details] > MozReview Request: bz://1159043/jryans > > https://reviewboard.mozilla.org/r/8489/#review7163 > > ::: toolkit/components/telemetry/Histograms.json:6565 > (Diff revision 1) > > + "kind": "boolean", > > boolean? Yeah, I am recording something like: key: x86_64|Darwin|40.0a1|firefox|40.0a1 value: true Boolean seemed[1] like the best type that also records multiple times during a session if needed. Note I am also using the fairly new "keyed" mode, which is why I can make up a complex key. There's no way to choose "string" as the value, so instead I am using a string "key" with true as the value. > ::: browser/devtools/webide/modules/app-manager.js:513 > (Diff revision 1) > > + let info = `${d.processor}|${d.os}|${d.platformversion}|${d.apptype}|${d.version}`; > > Are you sure you want such a complex key? > I don't know how is displayed this data but it may introduce a lot of > diversity in the possible key values. It's true I am overloading things here... The situation is that I need "keyed" histograms, since there is no defined set of values ahead of time. I could also instead break these values up into separate histogram probes for each segment. There is a small convenience with packing them together like this, since you know for sure that they all came together from the same event. If they are separate probes, it's a bit trickier to ask "What Gecko versions do Linux users connect to?", since you have to filter a probe against another. But, it may all be moot for the moment, since no existing dashboards can show keyed histograms at all. Instead, I'd need to run a custom data analysis[2] to access the data. I'll think a bit more about whether to pack into one key or use separate probes. Let me know if one or the other seems better to you! [1]: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe#Choosing_a_Histogram_Type [2]: http://telemetry-dash.mozilla.org/

https://reviewboard.mozilla.org/r/8489/#review7817 > Are you sure you want such a complex key? > I don't know how is displayed this data but it may introduce a lot of diversity in the possible key values. After some pratice with the data analysis pipeline, I am pretty sure I can get stitch things back together from separate telemetry probes. The updated patch now uses separate probes, instead of packing many fields into one probe.

Comment on attachment 8604169 [details] MozReview Request: bz://1159043/jryans /r/8491 - Bug 1159043 - Record WebIDE runtime info in Telemetry. r=ochameau Pull down this commit: hg pull -r 497088006e7c9d1f7f65a2c65661235eed4eb731 https://reviewboard-hg.mozilla.org/gecko/

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4b37a35a975

Comment on attachment 8604169 [details] MozReview Request: bz://1159043/jryans (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #6) > https://reviewboard.mozilla.org/r/8489/#review7817 > > > Are you sure you want such a complex key? > > I don't know how is displayed this data but it may introduce a lot of diversity in the possible key values. > > After some pratice with the data analysis pipeline, I am pretty sure I can > get stitch things back together from separate telemetry probes. > > The updated patch now uses separate probes, instead of packing many fields > into one probe. Looks much better! (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5) > Yeah, I am recording something like: > > key: x86_64|Darwin|40.0a1|firefox|40.0a1 > value: true > > Boolean seemed[1] like the best type that also records multiple times during > a session if needed. Hum, isn't `flag` better as it is always true? Again, I'm no telemetry expert, so whatever is better displayed in final dashboards is the best option!

(In reply to Alexandre Poirot [:ochameau] from comment #9) > (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5) > > Yeah, I am recording something like: > > > > key: x86_64|Darwin|40.0a1|firefox|40.0a1 > > value: true > > > > Boolean seemed[1] like the best type that also records multiple times during > > a session if needed. > > Hum, isn't `flag` better as it is always true? > Again, I'm no telemetry expert, so whatever is better displayed in final > dashboards is the best option! "flag" is usually the one I think of first too... but "flag" only allows one value to be recorded per Firefox session, so multiple connections would be missed. "boolean" does not have this limitation. Telemetry is confusing!

Backed out for test_telemetry.html failures. https://treeherder.mozilla.org/logviewer.html#?job_id=3172683&repo=fx-team

Backout: https://hg.mozilla.org/integration/fx-team/rev/9f78c9265052

I believe I've fixed the test issues: https://treeherder.mozilla.org/#/jobs?repo=try&revision=34c248ad9cdc

Comment on attachment 8620168 [details] MozReview Request: Bug 1159043 - Record WebIDE runtime info in Telemetry. r=ochameau Approval Request Comment [Feature/regressing bug #]: Collect additional telemetry about WebIDE usage [User impact if declined]: Most WebIDE users are on Dev. Ed, and it would be nice to accelerate collecting these metrics from them if possible. [Describe test coverage new/current, TreeHerder]: On m-c, test added. [Risks and why]: Low risk, only collects extra telemetry in WebIDE. [String/UUID change made/needed]: None

Aurora Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea1ec90bed1a Adjusted to remove testInChaosMode, since that does not exist in Aurora.