Closed Bug 1159091 Opened 10 years ago Closed 9 years ago

gecko: Show emulator-x86-kk as it's own platform

Categories

(Taskcluster :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlal, Assigned: edgar)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Quick update here... My most recent try push https://treeherder.allizom.org/#/jobs?repo=try&revision=ba3d90257f32 So on the TC side this is very simple (some in tree config changes) but somewhere in treeherder we seem to be filtering out some platforms (in this case kk :/) so I need to dig some more into what is going on under the hood.
Hi James, Do you have any update? Thanks
Flags: needinfo?(jlal)
Component: TaskCluster → General
Product: Testing → Taskcluster
This would help a lot to distinguish the test results of emu-kk and emu-x86-kk.
Looks like we could just add a new platform in https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L43. But I am not sure if there is other things need to be done in treeherder.
Depends on: 1144944
Attached patch [TC] Patch, v1 (obsolete) (deleted) — Splinter Review
Comment on attachment 8644774 [details] [treeherder:master] PR #842, Add platform mappings for emualtor x86 kk Currently the build result of emulator-x86-kk is put under `B2G KK Emulator` with x86 tag [1] and all the test of emulator-x86-kk and emulator-kk are mixed. It will be clearer if the result of emulator-kk and emulator-x86-kk could show in separated row. :) Hi :emorley, may I have your feedback here? Is any other thing need to be done in treeherder? Thank you. [1] https://treeherder.allizom.org/#/jobs?repo=try&revision=df9a7dd1362c
Attachment #8644774 - Flags: feedback?(emorley)
Attachment #8644777 - Flags: feedback?(emorley)
Comment on attachment 8644774 [details] [treeherder:master] PR #842, Add platform mappings for emualtor x86 kk This is everything that you need to do on the Treeherder side :-)
Attachment #8644774 - Flags: feedback?(emorley) → review+
Comment on attachment 8644777 [details] [diff] [review] [TC] Patch, v1 I'm not really familiar enough with the Taskcluster configs to know if this is now right.
Attachment #8644777 - Flags: feedback?(emorley)
Comment on attachment 8644777 [details] [diff] [review] [TC] Patch, v1 Review of attachment 8644777 [details] [diff] [review]: ----------------------------------------------------------------- Can you fix the | workerType: emualtor-x86-kk| typo in b2g_emulator_x86_kk_opt.yml while you're at it?
I have made sure that the "emulator-x86-kk" is available within our provisioner so that if the spelling change is corrected in the task definition, we do not have any interrupted service (hopefully).
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12) > Comment on attachment 8644777 [details] [diff] [review] > [TC] Patch, v1 > > Review of attachment 8644777 [details] [diff] [review]: > ----------------------------------------------------------------- > > Can you fix the | workerType: emualtor-x86-kk| typo in > b2g_emulator_x86_kk_opt.yml while you're at it? Sure, I will do this. And thanks Greg's comment in comment #13.
Assignee: jlal → echen
Attached patch [TC] Patch, v2 (deleted) — Splinter Review
Attachment #8644777 - Attachment is obsolete: true
Comment on attachment 8645764 [details] [diff] [review] [TC] Patch, v2 Try runs: https://treeherder.allizom.org/#/jobs?repo=try&revision=65e4b7b119fd I can see emulator-x86-kk build showing in separated platform, but still have `x86` tag. I thought |groupSymbol: "?"| would remove the `x86` tag, did I miss anything?
Flags: needinfo?(garndt)
Not sure what's going on here, but looking at the task definition [1] that was submitted, there is no mention of that group symbol. Perhaps this job name was cached on the treeherder side. I'm a bit at a loss. [1] https://queue.taskcluster.net/v1/task/VVE95Ym7TaOfzByCYrgKvg
Flags: needinfo?(garndt)
Comment on attachment 8645764 [details] [diff] [review] [TC] Patch, v2 Review of attachment 8645764 [details] [diff] [review]: ----------------------------------------------------------------- Since the task was submitted correctly, I would like to land this change first. Hi Greg, may I have your review? Thank you.
Attachment #8645764 - Flags: review?(garndt)
Comment on attachment 8645764 [details] [diff] [review] [TC] Patch, v2 Review of attachment 8645764 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8645764 - Flags: review?(garndt) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: