Closed
Bug 1159091
Opened 10 years ago
Closed 9 years ago
gecko: Show emulator-x86-kk as it's own platform
Categories
(Taskcluster :: General, defect)
Taskcluster
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Assigned: edgar)
References
Details
Attachments
(2 files, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Quick update here...
My most recent try push https://treeherder.allizom.org/#/jobs?repo=try&revision=ba3d90257f32
So on the TC side this is very simple (some in tree config changes) but somewhere in treeherder we seem to be filtering out some platforms (in this case kk :/) so I need to dig some more into what is going on under the hood.
Updated•9 years ago
|
Component: TaskCluster → General
Product: Testing → Taskcluster
Comment 3•9 years ago
|
||
This would help a lot to distinguish the test results of emu-kk and emu-x86-kk.
Blocks: emu-x86-kk-tests
Assignee | ||
Comment 4•9 years ago
|
||
Looks like we could just add a new platform in https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L43. But I am not sure if there is other things need to be done in treeherder.
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8644774 [details]
[treeherder:master] PR #842, Add platform mappings for emualtor x86 kk
Currently the build result of emulator-x86-kk is put under `B2G KK Emulator` with x86 tag [1] and all the test of emulator-x86-kk and emulator-kk are mixed. It will be clearer if the result of emulator-kk and emulator-x86-kk could show in separated row. :)
Hi :emorley, may I have your feedback here? Is any other thing need to be done in treeherder? Thank you.
[1] https://treeherder.allizom.org/#/jobs?repo=try&revision=df9a7dd1362c
Attachment #8644774 -
Flags: feedback?(emorley)
Assignee | ||
Updated•9 years ago
|
Attachment #8644777 -
Flags: feedback?(emorley)
Comment 8•9 years ago
|
||
Comment on attachment 8644774 [details]
[treeherder:master] PR #842, Add platform mappings for emualtor x86 kk
This is everything that you need to do on the Treeherder side :-)
Attachment #8644774 -
Flags: feedback?(emorley) → review+
Comment 9•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/84d8a71b716fe1dfea39631acb9632eaa6776125
Bug 1159091 - Add platform mappings for emulator x86 kk
Comment 10•9 years ago
|
||
Comment on attachment 8644777 [details] [diff] [review]
[TC] Patch, v1
I'm not really familiar enough with the Taskcluster configs to know if this is now right.
Attachment #8644777 -
Flags: feedback?(emorley)
Comment 11•9 years ago
|
||
I believe this is what you're looking for:
https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/builds/b2g_emulator_x86_kk_opt.yml#19
Flags: needinfo?(jlal)
Comment 12•9 years ago
|
||
Comment on attachment 8644777 [details] [diff] [review]
[TC] Patch, v1
Review of attachment 8644777 [details] [diff] [review]:
-----------------------------------------------------------------
Can you fix the | workerType: emualtor-x86-kk| typo in b2g_emulator_x86_kk_opt.yml while you're at it?
Comment 13•9 years ago
|
||
I have made sure that the "emulator-x86-kk" is available within our provisioner so that if the spelling change is corrected in the task definition, we do not have any interrupted service (hopefully).
Assignee | ||
Comment 14•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> Comment on attachment 8644777 [details] [diff] [review]
> [TC] Patch, v1
>
> Review of attachment 8644777 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Can you fix the | workerType: emualtor-x86-kk| typo in
> b2g_emulator_x86_kk_opt.yml while you're at it?
Sure, I will do this. And thanks Greg's comment in comment #13.
Assignee: jlal → echen
Assignee | ||
Comment 15•9 years ago
|
||
Attachment #8644777 -
Attachment is obsolete: true
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2
Try runs: https://treeherder.allizom.org/#/jobs?repo=try&revision=65e4b7b119fd
I can see emulator-x86-kk build showing in separated platform, but still have `x86` tag. I thought |groupSymbol: "?"| would remove the `x86` tag, did I miss anything?
Flags: needinfo?(garndt)
Comment 17•9 years ago
|
||
Not sure what's going on here, but looking at the task definition [1] that was submitted, there is no mention of that group symbol. Perhaps this job name was cached on the treeherder side. I'm a bit at a loss.
[1] https://queue.taskcluster.net/v1/task/VVE95Ym7TaOfzByCYrgKvg
Flags: needinfo?(garndt)
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2
Review of attachment 8645764 [details] [diff] [review]:
-----------------------------------------------------------------
Since the task was submitted correctly, I would like to land this change first.
Hi Greg, may I have your review? Thank you.
Attachment #8645764 -
Flags: review?(garndt)
Comment 19•9 years ago
|
||
Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2
Review of attachment 8645764 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8645764 -
Flags: review?(garndt) → review+
Updated•9 years ago
|
status-firefox43:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•