Closed Bug 1159308 Opened 10 years ago Closed 2 years ago

GC markers should fire on every incremental gc, not just when it's nonincremental

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jsantell, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [devtools-platform])

Currently the GC markers fire when a non-incremental GC occurs, containing the previous markers for inc. GC (usually). This has two side effects: * In the realtime timeline view, GC markers can render (as in our time, not the timeline's position, which is correct) way after when they occurred. While it's accurate, GC markers can just pop up on the timeline. Not a terrible side effect. * When nearing the end of a recording, or on a relatively light recording, the recording may complete before a non-inc GC event occurs, meaning we never get markers for all of the previous inc events that happened before the recording stopped. Some solutions are firing events on each inc marker (configurable?), forcing a GC at the end of a recording (would affect all recordings occuring), or continue listening to marker events after the recording ends and update the recording appropriately (this breaks many assumptions the tool is based on, and would make me cry)
Whiteboard: [devtools-platform]
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
Version: 37 Branch → unspecified
Product: Firefox → DevTools
Severity: normal → S3

This report is related to the old DevTools profiler implementation, which has been removed. The Performance panel is now based on Firefox Profiler at https://profiler.firefox.com/
Closing as invalid

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.