Closed
Bug 1159402
Opened 10 years ago
Closed 10 years ago
Remove the Zone-specialized pre-barrier
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
My discovery last week that we only need this for Value made me wonder if we need this at all 4 years of C and JS compiler development later. On my machine at least, I see no difference with and without.
Attachment #8598848 -
Flags: review?(sphink)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8598848 [details] [diff] [review]
remove_zone_specialized_barriers-v0.diff
Review of attachment 8598848 [details] [diff] [review]:
-----------------------------------------------------------------
It does remove a nice amount of code. I'm fine with passing it on to the gods of awfy to decide.
Attachment #8598848 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
|
||
Comment 5•10 years ago
|
||
AWFY detected a regression/improvement on:
- slave: Mac OS X 10.10 32-bit (Mac Pro, shell)
- mode: Ion
Regression(s)/Improvement(s):
- misc: -0.25% (improvement)
- misc: basic-strcat: -38.98% (improvement)
Recorded range:
- http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7723b15ea695&tochange=883ca6986e84
More details: http://arewefastyet.com/regressions/#/regression/1456549
|
|
Assignee | |
Comment 6•10 years ago
|
||
Wow, I really would not have expected that. Follow-on benefit of having less code, I suppose.
You need to log in
before you can comment on or make changes to this bug.
Description
•