Closed
Bug 1160164
Opened 10 years ago
Closed 10 years ago
"mach xpcshell-test" without a test path no longer works
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: past, Assigned: chmanchester)
References
Details
Attachments
(1 file, 1 obsolete file)
This used to work until yesterday and it still works for mochitest-chrome (mach mochitest-chrome --tag devtools), so the breakage seems to be xpcshell-specific:
$ mach xpcshell-test --tag devtools
From _tests: Kept 35668 existing; Added/updated 0; Removed 0 files and 0 directories.
We could not find an xpcshell test for the passed test path. Please select a path that is a test file or is a directory containing xpcshell tests.
$ head -2 toolkit/devtools/tests/unit/xpcshell.ini
[DEFAULT]
tags = devtools
Assignee | ||
Comment 2•10 years ago
|
||
|./mach xpcshell-test| with no arguments also does something crazy.
Summary: "mach xpcshell-test --tag devtools" no longer works → "mach xpcshell-test" without a test path no longer works
Assignee | ||
Comment 3•10 years ago
|
||
/r/7949 - Bug 1160164 - Run "all the tests" when invoking xpcshell's mach command with no arguments instead of passing "all" to the test resolver.;r=ahal
Pull down this commit:
hg pull -r f534458bd618ec771b1aecc2f77dccbb60f0f7b2 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599987 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 4•10 years ago
|
||
|./mach xpcshell-test| only sort of worked by accident before. "all" got passed to the test resolver, which interpreted each letter as a path input because strings are iterable, so any path with one of these inputs as a substring would match, meaning any test with "a" or "l" in its path would be run (this is all but 276 of 2,536 tests when I try it locally).
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8599987 [details]
MozReview Request: bz://1160164/chmanchester
Flag didn't get flipped.
Attachment #8599987 -
Flags: review?(ahalberstadt) → review+
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8599987 -
Attachment is obsolete: true
Attachment #8620202 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•