Closed
Bug 1160281
Opened 10 years ago
Closed 10 years ago
Add support for emulating -webkit-transform-origin via CSS unprefixing service
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: miketaylr, Assigned: miketaylr)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
miketaylr
:
review+
|
Details | Diff | Splinter Review |
It seems fairly trivial to map -webkit-transform-origin to transform-origin via the CSS unprefixing service.
For non-svg content, we pass essentially the same tests at http://test.csswg.org/harness/results/css-transforms-1_dev/grouped/section/8/, which leads me to believe this would be pretty safe (that is, fix more than it would break).
https://github.com/webcompat/web-bugs/issues/1026 is one known site that will need this.
Assignee | ||
Comment 1•10 years ago
|
||
Daniel, if you think this seems OK I'd be happy to write a patch and some tests. WDYT?
Blocks: CSSUnprefixingService
Assignee | ||
Comment 4•10 years ago
|
||
(...For some value of "tomorrow")
I'm working on this now, but will wait until https://hg.mozilla.org/integration/mozilla-inbound/rev/3efe5f06818d lands on m-c before uploading a patch for review.
Comment 5•10 years ago
|
||
Thanks! (& sorry if that commit bitrotted your patch)
Assignee | ||
Comment 6•10 years ago
|
||
Nah, have been busy poking at other things until now. No harm done.
Assignee | ||
Comment 7•10 years ago
|
||
Simple mapping of -webkit-transform-origin to transform-origin.
We could get pretty creative with the testing, but I just added the two actual instances used in one of the top Japan sites this fixes for us. It seems to be the most common usage on GitHub as well [1].
Once we get to r+, I'll push to Try.
[1] <https://github.com/search?p=99&q=-webkit-transform-origin&ref=simplesearch&type=Code&utf8=%E2%9C%93>
Assignee | ||
Comment 8•10 years ago
|
||
(just noticed I need a semicolon here):
> width: 500px
Comment 9•10 years ago
|
||
Comment on attachment 8603434 [details] [diff] [review]
1160281-Add-support-for-webkit-transform-origin.patch
>+++ b/layout/style/test/unprefixing_service_iframe.html
>+ // -webkit-transform-origin: <value> maps directly to "transform-origin"
>+ { decl: "-webkit-transform-origin: 0 0",
>+ targetPropName: "transform-origin",
>+ expectedDOMStyleVal: "0px 0px 0px",
>+ expectedCompStyleVal: "0px 0px" },
Nit: These 3 lines need 1 more space of indentation.
r=me with that
Attachment #8603434 -
Flags: review?(dholbert) → review+
Comment 10•10 years ago
|
||
(Is there any known difference in syntax between the prefixed & unprefixed versions in webkit-derived browsers, or are they just aliases as far as we know?)
Assignee | ||
Comment 11•10 years ago
|
||
Thanks for the review!
As far as I know, there are no reported differences between prefixed and unprefixed syntax. I spent a while trying to track things down on blogs, mailing lists and the Chromium bug tracker but didn't come up with anything. Nothing of note in the resources tab of caniuse [1] or Blink's intent to unprefix [2].
[1]http://caniuse.com/#feat=transforms2d
[2]https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vjyd8It--3Y
Comment 12•10 years ago
|
||
Great, thanks!
Assignee | ||
Comment 13•10 years ago
|
||
Addressed nits and carrying forward r+.
Let's see how Try feels about this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=900f57e8072e
Attachment #8603434 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
tracking-p11:
--- → +
Assignee | ||
Comment 14•10 years ago
|
||
There's some timeouts and some e10s bc1 failure that seem entirely unrelated, so setting to checkin-needed.
Keywords: checkin-needed
Comment 15•10 years ago
|
||
Keywords: checkin-needed
Comment 16•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•