Tamara Hills [:thills] Assignee
	Description • 9 years ago

For Spark/Lightsaber dogfooding users, we want to disable the checkbox that lets the user turn off the metrics.

This is only for the dogfooding users with a special build flag.

	Doug Sherk (:drs) (inactive)
	Comment 1 • 9 years ago

My understanding from an offline conversation was that we're not sure if we actually need to disable this checkbox or not, since we haven't confirmed the relation with that checkbox and the metrics pings.

	Tamara Hills [:thills] Assignee
	Comment 3 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

This patch modifies the FTU for dogfooding users so that the checkbox to turnoff the metrics is disabled and the user cannot manually disable the checkbox.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 4 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

I am not your FTU reviewer.

	Fernando Campo (:fcampo)
	Comment 5 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

Code looks ok, just couple of nits and a little improvement to the tests (github annotations).

I see from comment 1 that this is not 100% sure to land, I'd like to clarify that before merging. 

Also, when is exactly the settings flag ['debug.performance_data.dogfooding'] set and by who?

	Tamara Hills [:thills] Assignee
	Comment 6 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

Hi Fernando,

Thank you for the review.  I changed things around a little bit to not use a flag and just check the settings each time.  I made that modification in the test as well.  I had to modify the tests a bit to get it to work and wound up using a synch version of the MockSettings.

Bug 1160491 is what will be setting the setting.  This is part of the build system.. so, if we build with the flag DOGFOOD=1, that flag will be set.

Also, I did verify that we do need this because otherwise, user will be able to disable the metrics by checking this box.  

Thanks,

-tamara

	Doug Sherk (:drs) (inactive)
	Comment 7 • 9 years ago

Is there somewhere in Settings that the user can disable the metrics pings as well?

	Tamara Hills [:thills] Assignee
	Comment 8 • 9 years ago

Hi Doug,

You are right, it can be disabled from settings as well.  I filed 1168814 to care for this.

-tamara

	Fernando Campo (:fcampo)
	Comment 9 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

just couple more nits with spaces, and both tests use same description.

Also a question about the stored value (0/1 instead of false/true?) and coverage for enabling the checkbox.

Should I be able to test the code adding the setting to my user_prefs.js or do I need a specific build?

	Tamara Hills [:thills] Assignee
	Comment 10 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

Hi Fernando,

I changed it around little bit since I took your suggestion and changed the flag to true|false.  

To test it you can put the following lines in /build/settings.js at around line 284.  Then do a |DOGFOOD=1 make reset-gaia|

if (config.DOGFOOD === '1') {
    settings['debug.performance_data.dogfooding'] = true;
    settings['metrics.appusage.reportInterval'] = 24 * 60 * 60 * 1000;
  }

Let me know if you have questions.

Thanks,

-tamara

	Fernando Campo (:fcampo)
	Comment 11 • 9 years ago

Comment on attachment 8609838 [details]
[gaia] tamarahills:bugfix/1160488-disable-metrics-checkbox-dogfood > mozilla-b2g:master

Everything looks fine now, and manual tests worked nicely :)

thanks for the fixes!

	Tamara Hills [:thills] Assignee
	Comment 12 • 9 years ago

try:  https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e281c8a538975f6f5624dcc2f876b5195648bf1d

tests: https://github.com/mozilla-b2g/gaia/commit/933857f0fc38ef796ae3ed87bb7e69ca2dc90ff2