Closed
Bug 1160490
Opened 10 years ago
Closed 10 years ago
Windows 8 x64 spidermonkey shell build uses i686-pc-mingw32.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Derived from bug 1160137.
http://ftp.mozilla.org/pub/mozilla.org/spidermonkey/try-builds/arai_a@mac.com-5021b3857357/try-win64/try_win64_spidermonkey-compacting-bm79-try1-build2.txt.gz
> checking host system type... i686-pc-mingw32
> checking target system type... i686-pc-mingw32
> checking build system type... i686-pc-mingw32
that seems to be the reason why we get "error C2118: negative subscript" in opt build.
we should pass --target=x86_64-pc-mingw32 and --host=x86_64-pc-mingw32 from autospider.sh.
Assignee | ||
Comment 1•10 years ago
|
||
Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e8d0c02f82&exclusion_profile=false
at least it passes plain builds both with opt and debug.
Assignee | ||
Comment 2•10 years ago
|
||
Just added "--target=x86_64-pc-mingw32 --host=x86_64-pc-mingw32" to configure args for msys with win64.
Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e8d0c02f82&exclusion_profile=false
This also needs the patch for bug 1160137 to make it work with debug build (win64-debug)
Assignee: nobody → arai.unmht
Attachment #8600317 -
Flags: review?(sphink)
Comment 3•10 years ago
|
||
Comment on attachment 8600317 [details] [diff] [review]
Set target to x86_64 for spidermonkey shell build on Windows 8 x64.
Review of attachment 8600317 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good to me. Thanks! (I never did look closely at the win64 builds to see if they were doing something sensible.)
Attachment #8600317 -
Flags: review?(sphink) → review+
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 6•10 years ago
|
||
status-firefox39:
--- → fixed
Comment 7•10 years ago
|
||
status-firefox-esr38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•