Closed
Bug 1160562
Opened 10 years ago
Closed 10 years ago
Add-on install prompt no longer focuses when returning from different application
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
People
(Reporter: jryans, Unassigned)
References
()
Details
(Whiteboard: [fxsearch][hijacking])
STR:
1. Go to test URL
2. Click on the fxos-simulator-3.0-mac64.xpi
3. Click allow in the prompt to begin downloading
4. Switch to a different application
ER:
We should focus the window once downloading completes.
AR:
The dock icon did bounce once, but that's all.
I am pretty sure it used to be more "in your face" once downloading completed. Apologies if I'm just misremembering.
Comment 1•10 years ago
|
||
because we used to open a modal dialog it had the added effect of focusing the application window when opening. We should decide if we want to do this with the new doorhanger flow or maybe something like bouncing the dock icon/flashing the taskbar.
Markus, what are your thoughts?
Comment 2•10 years ago
|
||
Forcing Firefox in focus if another application is active is too much "in your face" as it will disrupt any task the user currently might be in, but I agree that we should notify the users that something has happened. Bouncing the dock icon/flashing the taskbar is a good solution for that. -> and should also make sure that the action is visible one Firefox is in focus again -> opening the doorhanger so that the user knows why they where notified.
Dave: Do we have system notification available? (growl style) And is there something like that on windows as well? If so, this would be a good solution.
Flags: needinfo?(mjaritz) → needinfo?(dtownsend)
Comment 3•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #1)
> maybe something like bouncing the dock icon/flashing the taskbar.
We're doing this already: http://hg.mozilla.org/mozilla-central/annotate/102d0e9aa9e1/toolkit/modules/PopupNotifications.jsm#l320
Comment 4•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #3)
> (In reply to Dave Townsend [:mossop] from comment #1)
> > maybe something like bouncing the dock icon/flashing the taskbar.
>
> We're doing this already:
> http://hg.mozilla.org/mozilla-central/annotate/102d0e9aa9e1/toolkit/modules/
> PopupNotifications.jsm#l320
So we are but it isn't terribly obvious as I missed it when I tested this first time around. The dock icon bounces just once, that's pretty easy to miss.
We do have the alerts service, that works like a notification centre message on OSX and a toast notification on windows and linux IIRC.
Flags: needinfo?(dtownsend)
Updated•10 years ago
|
Flags: firefox-backlog+
Whiteboard: [fxsearch][searchhijacking] → [fxsearch][hijacking]
Comment 5•10 years ago
|
||
[Tracking Requested - why for this release]:
This is something of a regression. Seems like the current alert maybe isn't strong enough but we don't want to be as in your face as we used to be. We either need to decide there is a middle ground we want or not do anything here.
status-firefox40:
--- → affected
tracking-firefox40:
--- → ?
Comment 6•10 years ago
|
||
We should track it for 40, to check that the download feedback design is sufficient. Also tracking 41, to ensure we catch it there, as well.
Philipp is this something you, or someone else, would decide?
Flags: needinfo?(philipp)
Comment 8•10 years ago
|
||
Since the current behavior is less disruptive to a users current task (which may be outside Firefox) and also more consistent with other downloads (which don't focus Firefox on completion either), we should keep it this way.
That said, there is a but that doesn't re-open the doorhanger when the user switches back to the tab from where it came, which we should fix. Markus, I believe you had a diagram or spec about that behavior.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(philipp) → needinfo?(mjaritz)
Resolution: --- → WONTFIX
Updated•10 years ago
|
Comment 9•10 years ago
|
||
To sum up: the current behaviour is good as it is. (If one switches application while downloading an addon, and even if they change the focused tab before that, they will be notified that the addon is ready to install by the dock-icon bouncing once. On returning to Firefox the tab installing the add-on from while be focused and the doorhanger is open.)
An extended problem is that the doorhanger is gone after Firefox loosing focus. As this does not only apply to add-on doorhangers there is a separate bug for that: https://bugzilla.mozilla.org/show_bug.cgi?id=1167701
Updated•10 years ago
|
Flags: needinfo?(mjaritz)
Setting status-firefox41 -> "won't fix" based on comment 8.
You need to log in
before you can comment on or make changes to this bug.
Description
•