Last one, time to finish this off. Note that the attached patch applies on top of the patches from bug 1160250. Try push shows a clean build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87ee17824b1c

Comment on attachment 8600379 [details] [diff] [review] Patch Review of attachment 8600379 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks for finishing this off! ::: gfx/layers/FrameMetrics.h @@ +254,5 @@ > + { > + mCompositionBounds = aCompositionBounds; > + } > + > + ParentLayerRect GetCompositionBounds() const Hmm, I noticed at some point we started writing getters that return structures by value rather than by reference-to-const (for example, GetViewport() returns by reference-to-const, but GetDisplayPort() doesn't). I would prefer returning by reference-to-const here, and fixing the others in a follow-up.

Updated to return const-ref, carrying r+

Pretty trivial change

Comment on attachment 8600461 [details] [diff] [review] Part 2 - Update other getters to return const-ref Review of attachment 8600461 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/c780203cf304 https://hg.mozilla.org/integration/mozilla-inbound/rev/bec29299cb7e

https://hg.mozilla.org/mozilla-central/rev/c780203cf304 https://hg.mozilla.org/mozilla-central/rev/bec29299cb7e