Closed
Bug 1160623
Opened 10 years ago
Closed 10 years ago
[Customizer] Fix script editor papercuts/visual design
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
Attachments
(1 file)
The recently-landed script editor did not have proper colors applied from UX. Need to apply the following colors as well as fix some previously mentioned papercuts (validation timing, scrolling past error message).
line numbers: #95368c
error message: #e51e1e
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jdarcangelo
Blocks: spark-customizer
Assignee | ||
Comment 1•10 years ago
|
||
Applied proper CSS colors from amylee. Also tried improving some of the timing around the JS validation as well as fixing the ability to scroll to the bottom line when an error message is displayed.
Attachment #8600430 -
Flags: review?(drs)
Comment 2•10 years ago
|
||
Comment on attachment 8600430 [details]
pull-request (master)
Looks good. I left one comment on the PR.
Attachment #8600430 -
Flags: review?(drs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Addressed review comment.
Landed on master:
https://github.com/fxos/customizer/commit/8a85f3457716923236ff1627890371d174c1b0cd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•