Closed
Bug 1160883
(Frisian-WordPrediction)
Opened 10 years ago
Closed 9 years ago
Add Frisian (fy or fy-NL) wordlist/dictionary
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: fryskefirefox, Assigned: rudyl)
References
Details
Attachments
(4 files)
This is a request to add Frisian wordlist/dictionary to Firefox OS.
The XML-file made by Kevin Scannell is attached.
What is the way to process this request?
Is there something I can do myself, like xml to dict with Python?
Comment 3•10 years ago
|
||
Hey Wim! I'll need info Kevin as I'm sure he has some tips :) thanks!
Flags: needinfo?(kscanne)
Comment 4•10 years ago
|
||
For the other dictionaries I've done, someone else has always landed the patch on github... not sure about the process.
Flags: needinfo?(kscanne)
Assignee | ||
Comment 6•10 years ago
|
||
We would need to get a keyboard layout implemented first, and then we could add the dictionary.
Could anyone on this provide a ref. to the keyboard layout we want for Frisian language?
If not, I'll try to find one from Android or other sources.
Flags: needinfo?(rlu)
Hi Rudy, you mean the one mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1153136 ?
Assignee | ||
Comment 8•10 years ago
|
||
Yes, thanks for bringing this up.
Let's mark the dependency and I am going to take a look at that patch.
Depends on: 1153136
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8611158 [details]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master
The layout and the dictionary are ready.
Tim, could you help review this?
Wim, if possible, please help take a look if the layout/dictionary is ok.
Thanks.
Attachment #8611158 -
Flags: review?(timdream)
Attachment #8611158 -
Flags: feedback?(fryskefirefox)
Reporter | ||
Comment 11•10 years ago
|
||
Hello Rudy Lu,
Thank you for all your hard work, really awesome!
I took the Dutch keyboard from github https://github.com/janjongboom/fxos-dutch-keyboard,
hacked it to the Frisian version and pushed it with WebIDE to my Flame.
And it works, both the wordsuggestions as well as the special characters.
If Tim agrees this bug and https://bugzilla.mozilla.org/show_bug.cgi?id=1153136 can be closed.
Comment 12•10 years ago
|
||
Comment on attachment 8611158 [details]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master
The dict need to be on the CDN too.
Attachment #8611158 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Hi Benson,
Could you please help review this, adding a new dictionary to our CDN?
Thanks.
Attachment #8612685 -
Flags: review?(bwong)
Comment 14•10 years ago
|
||
Comment on attachment 8612685 [details]
pr to update the CDN
Looks good. Merged
Attachment #8612685 -
Flags: review?(bwong) → review+
Comment 15•10 years ago
|
||
Shall I deploy this to the CDN?
Assignee | ||
Comment 16•10 years ago
|
||
Benson,
Yes, please.
Thanks a lot for your help.
Flags: needinfo?(bwong)
Reporter | ||
Comment 17•10 years ago
|
||
Comment on attachment 8611158 [details]
[gaia] RudyLu:keyboard/Bug1153136-Add_Frisian_layout > mozilla-b2g:master
File looks good.
Attachment #8611158 -
Flags: feedback?(fryskefirefox) → feedback+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 20•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#ztZnQQTDTUStQsfEvWmf7g
The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee | ||
Comment 21•9 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/b6c5fda821dce99babf8b9d5799a95eb4aeca64a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
Comment 22•9 years ago
|
||
Josh: once more this is a locale that was 100% completed and tested on 2.2, and that we can sign-off on l10n side if they get the autocorrection in. Since this is minimal risk patch, can we get an approval to land on 2.2?
Flags: needinfo?(jocheng)
Updated•9 years ago
|
status-b2g-v2.2:
--- → affected
Flags: needinfo?(jocheng)
Assignee | ||
Comment 24•9 years ago
|
||
Flags: needinfo?(rlu)
Assignee | ||
Comment 25•9 years ago
|
||
Comment on attachment 8626498 [details]
Patch for v2.2
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New feature, a new keyboard layout
[User impact] if declined: The native Frisian user would not have keyboard to input.
[Testing completed]: Yes, manually
[Risk to taking this patch] (and alternatives if risky): Low, the newly added keyboard layout won't be enabled if not explicitly specified.
[String changes made]: N/A
Attachment #8626498 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
blocking-b2g: --- → 2.2+
status-b2g-v2.5:
--- → fixed
Updated•9 years ago
|
Attachment #8626498 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 26•9 years ago
|
||
Target Milestone: --- → FxOS-S1 (26Jun)
Updated•9 years ago
|
status-b2g-v2.5:
fixed → ---
Updated•9 years ago
|
Blocks: WordPrediction
Updated•9 years ago
|
Alias: Frisian-WordPrediction
You need to log in
before you can comment on or make changes to this bug.
Description
•