Closed
Bug 116101
Opened 23 years ago
Closed 23 years ago
charset conversions for local mail folder paths
Categories
(MailNews Core :: Internationalization, defect)
MailNews Core
Internationalization
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: nhottanscp, Assigned: nhottanscp)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
naving
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
There are charset conversions for local mail folder path (between Unicode and OS
native charset).
NS_MsgCreatePathStringFromFolderURI - converts from unicode to native (1543
micro seconds per call)
nsMsgGetNativePathString - converts from native to unicode (353 micro seconds
per call)
So they are not really slow but might be able to improve.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Here is results with the patch, the account only has ASCII folders.
NS_MsgCreatePathStringFromFolderURI - 87.47
nsMsgGetNativePathString - 5.78
The ASCII check is not expensive (about 1 micro second) so this won't slow down
non ASCII cases.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Assignee | ||
Comment 3•23 years ago
|
||
Attachment #62279 -
Attachment is obsolete: true
Comment 4•23 years ago
|
||
Comment on attachment 62281 [details] [diff] [review]
indentation change
r=naving, makes sense
Attachment #62281 -
Flags: review+
Comment 5•23 years ago
|
||
Comment on attachment 62281 [details] [diff] [review]
indentation change
sr=sspitzer
Attachment #62281 -
Flags: superreview+
Assignee | ||
Comment 6•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Naoki, could you help verifying this bug? thanks much.
QA Contact: ji → nhotta
Assignee | ||
Comment 8•23 years ago
|
||
verified
nsMsgUtils.cpp, rev=1.60
nsMsgI18N.cpp, rev=1.61
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•