I believe this was done originally so that the connection was separate from the ProfilerFront -- no longer the case, as PerformanceFront is a fake front that just exposes methods from the shared connection. These should be consolidated, unless there's a scenario or reason I'm not considering.

Thoughts?

What is performanceSharedActionsConnection?

Yeah it looks like the PerformanceActorsConnection has evolved into a generally useless wrapper. Good idea to merge now.

Comment on attachment 8616413 [details] [diff] [review] 1161199-perffront-refactor.patch Review of attachment 8616413 [details] [diff] [review]: ----------------------------------------------------------------- very clean ::: browser/devtools/framework/toolbox.js @@ +1897,5 @@ > + return this.performance; > + } > + > + this._performance = getPerformanceFront(this.target); > + Nit: extra newline.

rebased, nits fixed

Chunk failure, landing last chunk separately https://hg.mozilla.org/integration/fx-team/rev/d0cce7e6e92b

https://hg.mozilla.org/mozilla-central/rev/6286e15a806d https://hg.mozilla.org/mozilla-central/rev/d0cce7e6e92b