Closed
Bug 116134
Opened 23 years ago
Closed 23 years ago
mimemoz2.cpp, pass a length of converted string to save strlen() call per line
Categories
(MailNews Core :: Internationalization, defect)
MailNews Core
Internationalization
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: nhottanscp, Assigned: nhottanscp)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bugzilla
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
mime_convert_charset() calls ConvertUsingEncoderAndDecoder() to apply charset
conversion for message body. mime_convert_charset() calls strlen() per line
because converted length is not returned from ConvertUsingEncoderAndDecoder.
Adding length as an output can save one strlen() call per line.
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
|
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Comment on attachment 64057 [details] [diff] [review]
Change the conversion function to return a length to eliminate unnecessary strlen by the caller.
R=ducarroz
Attachment #64057 -
Flags: review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 64057 [details] [diff] [review]
Change the conversion function to return a length to eliminate unnecessary strlen by the caller.
sr=sspitzer
Attachment #64057 -
Flags: superreview+
|
|
Assignee | |
Comment 4•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Naoki, could you help verifying this bug? Thanks much.
QA Contact: ji → nhotta
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•