Mike Conley (:mconley) (:⚙️) Reporter
	Description • 9 years ago

Bug 984821 disabled browser_CTP_iframe.js because it orange'd pretty often. jimm ended up refactoring that test to use Promises in bug 1129040, so I suspect this might have ironed out some of the race conditions that the old form of the test had.

I think we should try re-enabling the test.

	Jim Mathies [:jimm]
	Comment 1 • 9 years ago

still disabled.

	Trevor Rowbotham [:rowbot] Assignee
	Comment 2 • 9 years ago

This test seems to be working fine in my linux VM, let's try re-enabling it.

	Jim Mathies [:jimm]
	Comment 3 • 9 years ago

Comment on attachment 8639408 [details] [diff] [review]
bug1161564_reenable_browser_ctp_iframe_test.diff

Review of attachment 8639408 [details] [diff] [review]:
-----------------------------------------------------------------

Do you need try pushes for this? (ni me if you do, otherwise I'll forget.)

	Trevor Rowbotham [:rowbot] Assignee
	Comment 4 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98c5b30963c5

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a09752ef90bb

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/a09752ef90bb