Closed
Bug 1161638
Opened 10 years ago
Closed 9 years ago
Remove the chrome at the bottom of the screen in the Tabs Tray
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox39 wontfix, firefox40 affected, firefox43 fixed, relnote-firefox 44+)
RESOLVED
FIXED
Firefox 43
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(4 files)
We may want to consider removing the chrome at the bottom of the tabs tray:
- we don't have it on tablet - it raises the question of why we need to retain this on mobile
- it blocks tabs which are content which would be useful to see more of
- it's original purpose was that it's there to show you where you were and how to get back, but we have a highlighted tab to show you where you were so why duplicate? Also the need to give users a visible way back is tired - users know how to use the back button!
- We could clean up the code and layout a load if we removed this dependency - browser app and tabs tray could be completely different activities (or even fragments!)
Comment 1•10 years ago
|
||
I'd agree with this direction. Could we get a build to test? The added space could bring other benefits like cleaning up the visuals under our current "super toasts", more space for visual tabs (especially in landscape mode), etc..
Comment 2•10 years ago
|
||
Here's a quick comparison I did for the landscape view.
Comment 3•10 years ago
|
||
[Tracking Requested - why for this release]:
https://bugzilla.mozilla.org/show_bug.cgi?id=1132508 this relates to and could potentially fix this bug which is 39+, worth keeping track of.
tracking-firefox39:
--- → ?
Comment 4•10 years ago
|
||
[Tracking Requested - why for this release]:
Tracking requested for 40 as well for the same reasons as above.
tracking-firefox40:
--- → ?
Updated•10 years ago
|
Sounds like a good possible solution. It is getting pretty late in the beta cycle to take this for 39, though. Let's track it for 40 and see how it goes. Martin if you do come up with something please request uplift.
Wontfix for 39.
Assignee | ||
Comment 7•9 years ago
|
||
So this doesn't seem to be just about removing the chrome from the screen, we should also change the layout of the tabs panel from a list to a grid, otherwise the landscape view looks terrible (see attached). This will also mean that we need to switch the layout of the tab items to the same as the tablet version.
Comment 8•9 years ago
|
||
(In reply to Martyn Haigh (:mhaigh) from comment #7)
> So this doesn't seem to be just about removing the chrome from the screen,
> we should also change the layout of the tabs panel from a list to a grid,
In which case, I'd argue we need to implement swipe-to-close for the grid (bug 1017338) first.
Assignee | ||
Comment 9•9 years ago
|
||
Note: Remember to remove the negative margin in the private_tabs_panel.xml file when we do this.
Comment 10•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #8)
> (In reply to Martyn Haigh (:mhaigh) from comment #7)
> > So this doesn't seem to be just about removing the chrome from the screen,
> > we should also change the layout of the tabs panel from a list to a grid,
>
> In which case, I'd argue we need to implement swipe-to-close for the grid
> (bug 1017338) first.
Thats a good point as well.
Updated•9 years ago
|
Comment 11•9 years ago
|
||
I don't think this needs to track a release.
Martyn, what do you think?
Flags: needinfo?(mhaigh)
Comment 12•9 years ago
|
||
(If that's the case, let's re-nom, so I can stop getting all these release tracking emails!)
Assignee | ||
Comment 13•9 years ago
|
||
This is more a thing I'm hacking on in the background - no release needs to be tracked as far as I'm concerned.
Flags: needinfo?(mhaigh)
Comment 14•9 years ago
|
||
[Tracking Requested - why for this release]: This bug doesn't need to track a release.
(Process question: would it be okay for me to just clear these values myself in the future?)
Comment 15•9 years ago
|
||
Removed the tracking requests for 39 and 40. I think that's how this should be handled (my first time removing tracking requests). Needing info from lmandel, as a backup.
Comment 16•9 years ago
|
||
I meant to state why I was removing tracking — which is as stated in the comments above, esp Comment 14, where this doesn't need to be tracked with a release, any longer.
Comment 17•9 years ago
|
||
(In reply to :Margaret Leibovic from comment #14)
> (Process question: would it be okay for me to just clear these values myself
> in the future?)
Yes. Can I request that you also drop a quick ni or e-mail to the release manager in charge of the release so that they know that the bug has dropped off of their list?
Flags: needinfo?(lmandel)
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Bug 1161638 - Remove the chrome at the bottom of the screen in the Tabs Tray; r?sebastian
I'm not planning on landing this just yet, it's part of a bigger piece of work which I can't pref off, so I'm going to get the majority of it going through review before anything lands properly.
Attachment #8646389 -
Flags: review?(s.kaspari)
Comment 20•9 years ago
|
||
Comment on attachment 8646389 [details]
MozReview Request: Bug 1161638 - Remove the chrome at the bottom of the screen in the Tabs Tray; r?sebastian
https://reviewboard.mozilla.org/r/15727/#review14177
Ship It!
Attachment #8646389 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 21•9 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/2471a8b82aa162429d68c15ff2702934747c8955
changeset: 2471a8b82aa162429d68c15ff2702934747c8955
user: Martyn Haigh <mhaigh@mozilla.org>
date: Thu Jun 11 14:12:24 2015 +0100
description:
Bug 1161638 - Remove the chrome at the bottom of the screen in the Tabs Tray; r=sebastian
I'm not planning on landing this just yet, it's part of a bigger piece of work which I can't pref off, so I'm going to get the majority of it going through review before anything lands properly.
Assignee | ||
Comment 22•9 years ago
|
||
aiming to get this in to 44 - so let's land it!
https://hg.mozilla.org/integration/fx-team/rev/2471a8b82aa1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 24•9 years ago
|
||
Tested using:
Device: LG Nexus 4 (Android 5.0)
Build: Firefox for Android 43.0a1 (2015-08-17)
Last tab is cut off in tab tray in portrait, so I filled Bug 1195216 for this issue.
Comment 25•9 years ago
|
||
Margaret, also this is in 44/Aha. Is this still valid, if so, we probably need to add this to the rel notes?
Flags: needinfo?(margaret.leibovic)
Comment 26•9 years ago
|
||
(In reply to Barbara Bermes [:barbara] from comment #25)
> Margaret, also this is in 44/Aha. Is this still valid, if so, we probably
> need to add this to the rel notes?
Yes, this is the fullscreen tabs tray.
I think this should be covered by "Improved tabs tray on phones".
Flags: needinfo?(margaret.leibovic)
Barbara, please nominate this one for relnotes too by setting tracking flag relnote-firefox to "?". Thanks!
Flags: needinfo?(bbermes)
Comment 28•9 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: Removed chrome from the bottom of the screen in the tabs tray mode, clean-up
[Suggested wording]: Improved tabs tray on phones
[Links (documentation, blog post, etc)]: n/a yet?
relnote-firefox:
--- → ?
Flags: needinfo?(bbermes) → needinfo?(jsavage)
Added to Beta44 release notes.
Comment 30•9 years ago
|
||
Our contributor, Biraj, has updated this article (thanks, Biraj!) https://support.mozilla.org/en-US/kb/using-tabs-firefox-android
Flags: needinfo?(jsavage)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•