Closed Bug 1162329 Opened 10 years ago Closed 9 years ago

Enable test_form_autocomplete_with_list.html for e10s

Categories

(Toolkit :: Autocomplete, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m7+ ---
firefox41 --- fixed

People

(Reporter: mrbkap, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Over in bug 1024437, MattN noticed that the satchel tests are all disabled in e10s. We should get the re-enabled. test_form_autocomplete.html has been disabled for a year and change and no longer passes (see bug 874429). Other than that test, the most useful one seems to be the _with_list.html variant. As I tried to enable it, though, I found several partially-implemented features in the e10s autocomplete code. I'll file bugs on what I found.
The e10s autocomplete popup doesn't pop back up if nsAutoCompleteController.cpp decides to reuse its cached autocomplete result. We need to detect when this happens and open the popup in the parent.
Attachment #8602455 - Flags: review?(felipc)
Attached patch Fix display label vs. value (deleted) — Splinter Review
The current code only grabs the value, but datalist entries can have separate values (what's submitted/put in the input if selected) and labels (what's displayed in the autocomplete popup.
Attachment #8602456 - Flags: review?(felipc)
Assignee: nobody → mrbkap
Attachment #8602455 - Flags: review?(felipc) → review+
Attachment #8602456 - Flags: review?(felipc) → review+
Attached patch Make dynamic changes to the datalist work (obsolete) (deleted) — Splinter Review
I was not able to make the test pass in its entirety. There are subtle timing problems that I wasn't able to make consistent across the e10s and non-e10s versions of the test. With the patches in this bug, then if I "nudge" the test by re-opening autocomplete menus when expected, the test passes. I'm going to leave the test in this state for the moment and file a followup bug to fix the timing problems.
Attachment #8607264 - Flags: review?(MattN+bmo)
Attachment #8607264 - Attachment is obsolete: true
Attachment #8607264 - Flags: review?(MattN+bmo)
Attachment #8609043 - Flags: review?(felipc) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1230872
Depends on: 1300919
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: