Closed Bug 1162692 Opened 10 years ago Closed 10 years ago

Add preffed SpeechSynthesisUtterance.chosenVoiceURI for testing purposes

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file, 1 obsolete file)

We need to test correct voice selection in content mochitests. Currently, we do that with implementing a service via SpecialPowers. This doesn't work well with e10s tests, so it would be nice if there was a lightweight way of knowing what voice was ultimately chosen for a spoken utterance.
Assignee: nobody → eitan
Attachment #8602940 - Flags: review?(bugs)
Comment on attachment 8602940 [details] [diff] [review] Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. > } > >+ > nsresult Don't add that extra new line. Would [ChromeOnly] work for chosenVoiceURI? But Pref is fine too.
Attachment #8602940 - Flags: review?(bugs) → review+
Made it ChromeOnly and removed newline. Carrying over r+
Attachment #8602940 - Attachment is obsolete: true
Comment on attachment 8603081 [details] [diff] [review] Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. r=smaug I meant only ChromeOnly, not both ChromeOnly and Pref ;)
Good point! I'll change that before pushing.
Blocks: 1162699
Looks like we were crashing when activating the screen reader with no available voices. We were dereferencing a null pointer. I'll move that line after the null-check and it should be good. Try is happy.
Flags: needinfo?(eitan)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: