Closed
Bug 1162692
Opened 10 years ago
Closed 10 years ago
Add preffed SpeechSynthesisUtterance.chosenVoiceURI for testing purposes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file, 1 obsolete file)
We need to test correct voice selection in content mochitests. Currently, we do that with implementing a service via SpecialPowers. This doesn't work well with e10s tests, so it would be nice if there was a lightweight way of knowing what voice was ultimately chosen for a spoken utterance.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → eitan
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8602940 -
Flags: review?(bugs)
Comment 2•10 years ago
|
||
Comment on attachment 8602940 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes.
> }
>
>+
> nsresult
Don't add that extra new line.
Would [ChromeOnly] work for chosenVoiceURI?
But Pref is fine too.
Attachment #8602940 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Made it ChromeOnly and removed newline.
Carrying over r+
Attachment #8602940 -
Attachment is obsolete: true
Comment 4•10 years ago
|
||
Comment on attachment 8603081 [details] [diff] [review]
Add SpeechSynthesisUtterance.chosenVoiceURI for testing purposes. r=smaug
I meant only ChromeOnly, not both ChromeOnly and Pref ;)
Assignee | ||
Comment 5•10 years ago
|
||
Good point! I'll change that before pushing.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/05e4643b27ec for apparently causing the Gip(a) permafail on inbound:
https://treeherder.mozilla.org/logviewer.html#?job_id=9712726&repo=mozilla-inbound
Flags: needinfo?(eitan)
Assignee | ||
Comment 8•10 years ago
|
||
Looks like we were crashing when activating the screen reader with no available voices. We were dereferencing a null pointer.
I'll move that line after the null-check and it should be good. Try is happy.
Flags: needinfo?(eitan)
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•