Closed
Bug 1162752
Opened 10 years ago
Closed 10 years ago
Exit from DOM fullscreen to fullscreen mode cause toolbar automatically collapse on OS X
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | unaffected |
| firefox38.0.5 | --- | unaffected |
| firefox39 | --- | unaffected |
| firefox40 | --- | verified |
| firefox41 | --- | verified |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dao
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The fullscreen mode on OS X >= 10.7 normally does not hide the toolbar. But after bug 947854, there is a regression that when returning from DOM fullscreen to fullscreen mode, the toolbar will automatically hide.
I'll look into it this weekend. It should be fixed in Firefox 40 anyway. I don't want it to become a regression.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8603628 -
Flags: review?(dao)
|
|
Assignee | |
Updated•10 years ago
|
status-firefox38:
--- → unaffected
status-firefox38.0.5:
--- → unaffected
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
status-firefox41:
--- → affected
|
||
Updated•10 years ago
|
Attachment #8603628 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8603628 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: bug 947854
[User impact if declined]: on OS X >= 10.7, the toolbar will be unexpectedly hidden when exit from DOM fullscreen to fullscreen mode
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: pretty low risk since the code changed affects only Mac, and the logic here looks simple
[String/UUID change made/needed]: n/a
Attachment #8603628 -
Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8603628 [details] [diff] [review]
patch
Recent regression, taking it.
Attachment #8603628 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 6•10 years ago
|
||
|
||
Comment 7•9 years ago
|
||
Verified as fixed using Firefox 40 beta 2 and latest Aurora 41.0a2 2015-07-08 under Mac OS X 10.9.5.
You need to log in
before you can comment on or make changes to this bug.
Description
•