Closed
Bug 1162781
Opened 10 years ago
Closed 8 years ago
Several test failures in testSessionStore/testUndoTab.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox40 disabled)
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox40 | --- | disabled |
People
(Reporter: whimboo, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [mozmill-test-failure][mozmill-test-skipped])
Attachments
(1 file)
(deleted),
patch
|
whimboo
:
checkin+
|
Details | Diff | Splinter Review |
This is a recent regression for the testSessionStore/testUndoTab.js test module which started May 6th. A Nightly from May 5th works like expected.
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c93d46ab92f&tochange=60349cbc3d4e
Failures:
"fail": {
"message": "'Undo Close Tab' is disabled - got 'false'",
"fileName": "file:///mozilla/code/mozmill-tests/nightly/firefox/tests/functional/testSessionStore/testUndoTab.js",
"name": "testUndoTabFromContextMenu",
"lineNumber": 49
}
"message": "'Recently Closed Tabs' sub menu has to be empty - '2' should equal '0'",
"lineNumber": 54,
"name": "Error",
"fileName": "file:///mozilla/code/mozmill-tests/nightly/firefox/tests/functional/testSessionStore/testUndoTab.js"
"message": "'Recently Closed Tabs' sub menu entries have changed - '3' should equal '2'",
"lineNumber": 855,
"name": "Error",
"fileName": "file:///mozilla/code/mozmill-tests/nightly/firefox/lib/tabs.js"
Reporter | ||
Updated•10 years ago
|
Priority: -- → P1
Reporter | ||
Comment 1•10 years ago
|
||
For now lets skip this test.
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8603193 [details] [diff] [review]
skip patch
https://hg.mozilla.org/qa/mozmill-tests/rev/7e895028f703 (default)
Attachment #8603193 -
Flags: checkin+
Comment hidden (obsolete) |
Reporter | ||
Comment 4•10 years ago
|
||
Tim, do you have any idea if your patch on bug 1160556 could have caused this different behavior? Otherwise I cannot find anything else related to sessionstore in the pushlog.
Flags: needinfo?(ttaubert)
Reporter | ||
Updated•10 years ago
|
status-firefox40:
--- → disabled
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
Comment 5•10 years ago
|
||
That's more likely caused by bug 1109875 that made state collection for closing tabs asynchronous. This shouldn't really matter in normal usage but would probably break a few tests that close a tab and in the same tick expect all state to be saved and "undo-closeable".
Flags: needinfo?(ttaubert)
Reporter | ||
Comment 6•10 years ago
|
||
Indeed, that sounds like it is the problem here. Thanks Tim! Given the amount of work I would have to put in here, I will keep this test skipped. Once we convert the sessionstore tests to Firefox UI Tests, we will pick up this information and handle the event properly.
Blocks: 1109875
Keywords: regressionwindow-wanted
Reporter | ||
Comment 7•8 years ago
|
||
Mozmill tests have been superseded by Marionette tests.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•