Closed
Bug 1163107
Opened 10 years ago
Closed 9 years ago
Changes to font size not respected when using relative filter units
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: tschneider, Unassigned)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
When changing the font size after a filter using relative units was set, the change is not respected when the filter gets applied.
|
||
Comment 1•9 years ago
|
||
Hmm. Maybe we should just define the current Firefox behavior as correct. It's similar to how ctx.font works:
> When the 'font-size' component is set to lengths using percentages, 'em' or
> 'ex' units, or the 'larger' or 'smaller' keywords, these must be interpreted
> relative to the computed value of the 'font-size' property of the font style
> source node at the time that the attribute is set, if that is an element.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
http://www.w3.org/TR/2015/WD-2dcontext-20150514/#dom-context-2d-font
|
||
Updated•9 years ago
|
Whiteboard: [gfx-noted]
|
Reporter | |
Comment 2•9 years ago
|
||
I agree, It makes most sense to make it work just like ctx.font.
|
|
Reporter | |
Comment 3•9 years ago
|
||
Change test to reflect previously discussed behavior.
Attachment #8603497 -
Attachment is obsolete: true
Attachment #8738904 -
Flags: review?(mstange)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8738904 [details] [diff] [review]
test case
Review of attachment 8738904 [details] [diff] [review]:
-----------------------------------------------------------------
Can you also add a test that makes sure that we *don't* react to font changes that happen after the filter was set?
Attachment #8738904 -
Flags: review?(mstange) → review+
|
|
Reporter | |
Comment 5•9 years ago
|
||
That's what the test is already doing. It changes the font size to 20px after setting the filter, which should get ignored.
|
|
||
Comment 6•9 years ago
|
||
Oh, right.
|
|
Reporter | |
Comment 7•9 years ago
|
||
|
|
Reporter | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•