Closed
Bug 1163810
Opened 10 years ago
Closed 10 years ago
Use type-based dispatch for IncrementalReferenceBarrier
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8604325 -
Flags: review?(jcoppeard)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8604325 [details] [diff] [review]
28_typed_dispatch_for_incrementalreferencebarrier-v0.diff
Review of attachment 8604325 [details] [diff] [review]:
-----------------------------------------------------------------
Great!
::: js/src/vm/Symbol.h
@@ +63,5 @@
> inline void finalize(js::FreeOp*) {}
>
> + static MOZ_ALWAYS_INLINE void writeBarrierPre(Symbol* thing) {
> + if (thing && !thing->isWellKnownSymbol())
> + thing->asTenured().writeBarrierPre(thing);
Is this just to call the version in TenuredCell? Writing |TenuredCell::writeBarrierPre(thing)| would be clearer I think.
Oh, I see we do this in the other implementations too, so no big deal.
Attachment #8604325 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
Well, try is still green, let's try this patch separately.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70260d204dca
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•