From Bugzilla Helper: User-Agent: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) BuildID: 20011205 While running the "replace all" part of the fillowing test: http://www.mozilla.org/quality/browser/front-end/testcases/composer/composer- find-replace.html I had to hit "Replace All" twice in order to replace everything in the document when doing a Search Backwards Reproducible: Always Steps to Reproduce: 1. Enter the following lines in Composer: The the Theory theory why The 2. From the beginning of the doc, Select Edit|Find Replace and checkoff the "Match upper/lower case" box and enter "The" for the Find, and enter "Sam" for the Replace with. Hit "Replace All" 3. You should now see: Sam the Samory theory why Sam 4. Now click on the search backwards box and change the Find field to "Sam" and the Replace with field to "The". Hit "Replace All" Actual Results: on the backwards search, only the last occurance is replaced when you hit replace all. You need to click replace all again to get the' rest changed. Expected Results: All occurances should be changed. I reproduced this on OpenVMS as well as on a Linux box I have.

-->Akkana for triage

The find/replace code is about to change, so I'm adding a dependency on those bugs. Will look at this one when those are in.

New find/replace is in now ... and testing this bug, it turns out that we're not doing the right thing in the case of reverse find with wraparound. We don't show the particular problem that the old find showed, but we do have other problems (like, it doesn't wrap, and can hang if the replacement string will match the match pattern, e.g. replace a with aa). Confirming/accepting this bug so that I can attach my patch for those problems.

This patch sets the start/end points of the searches correctly for the reverse case if reverse is checked.

Jfrancis noticed that startPt wasn't being used any more and so should be deleted.

Comment on attachment 74828 [details] [diff] [review] Delete unused variable dont see any other probs.

Comment on attachment 74828 [details] [diff] [review] Delete unused variable sr=sfraser

Comment on attachment 74828 [details] [diff] [review] Delete unused variable a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Fixed.

Trying again to mark as fixed.