Closed
Bug 1164235
Opened 10 years ago
Closed 10 years ago
Add theme_color support to web manifest processor
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Add support for processing theme_color to web manifest, and generalize CSS color processing.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mcaceres
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Adds support for theme_color and generalizes color validation for background_color too.
Attachment #8605446 -
Flags: review?(ehsan)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8605446 [details] [diff] [review]
0001-Bug-1164235-Add-theme_color-support-to-web-manifest-.patch
Review of attachment 8605446 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/manifest/ManifestValueExtractor.jsm
@@ +23,5 @@
> +
> +ManifestValueExtractor.prototype = {
> + extractValue({
> + expectedType, object, objectName, property, trim
> + }) {
Can you please add a comment explaining what this is doing?
Attachment #8605446 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8605446 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•10 years ago
|
||
Cancelled other try. New try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=373f23ea1923
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•