Closed Bug 1164426 Opened 10 years ago Closed 10 years ago

Build blocklist of sites where we do not want to offer reader mode into toolkit isProbablyReaderable invocation

Categories

(Toolkit :: Reader Mode, defect)

Product:
Toolkit
Component:
Reader Mode
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox38.0.5 --- verified
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1164426 - build reader mode blocklist, r?margaret
(deleted), text/x-review-board-request
Margaret
: review+
Details
Prime candidates: twitter.com reddit.com github.com mail.google.com (I occasionally see reader mode icons on gmail... I've not had time to investigate, but it's definitely not useful, and wrong)
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Status: NEW → ASSIGNED
Attached file MozReview Request: bz://1164426/Gijs (obsolete) (deleted) —
/r/8795 - Bug 1164426 - build reader mode blocklist, r?margaret Pull down this commit: hg pull -r e1f055e136ba52d15d682a02bf0bcfc5255fe1b4 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606044 - Flags: review?(margaret.leibovic)
https://reviewboard.mozilla.org/r/8795/#review7483 This will affect mobile as well, but I don't think there are any sites where we would want different behvaior for desktop/mobile.
Comment on attachment 8606044 [details] MozReview Request: bz://1164426/Gijs https://reviewboard.mozilla.org/r/8793/#review7485 Ship It!
Attachment #8606044 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8606044 [details] MozReview Request: bz://1164426/Gijs Approval Request Comment [Feature/regressing bug #]: reader mode [User impact if declined]: spurious reader mode offers [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: very low, simple change [String/UUID change made/needed]: no
Attachment #8606044 - Flags: approval-mozilla-release?
Attachment #8606044 - Flags: approval-mozilla-beta?
Attachment #8606044 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/353afeed8cf2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8606044 [details] MozReview Request: bz://1164426/Gijs Should be in 38.0.5b3.
Attachment #8606044 - Flags: approval-mozilla-release?
Attachment #8606044 - Flags: approval-mozilla-release+
Attachment #8606044 - Flags: approval-mozilla-beta?
Attachment #8606044 - Flags: approval-mozilla-beta+
Attachment #8606044 - Flags: approval-mozilla-aurora?
Attachment #8606044 - Flags: approval-mozilla-aurora+
Confirmed fixed on 38.0.5b3 (20150518141916), using Ubuntu 14.04 (x64) and Mac OS X 10.9.5 with several pages from the domains mentioned in Comment 0.
Status: RESOLVED → VERIFIED
status-firefox38.0.5: fixed → verified
QA Contact: andrei.vaida
Removing qe-verify+ since verification on 38.0.5 Beta should suffice.
Flags: qe-verify+
Attachment #8606044 - Attachment is obsolete: true
Attachment #8620281 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: