Closed
Bug 1164593
Opened 10 years ago
Closed 9 years ago
Import file UI has a title "Save profile..."
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
(deleted),
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Should be "Import recording..." -- and we should probably save the save prompt to be "Save recording..." as well.
Assignee | ||
Updated•10 years ago
|
Blocks: perf-tool-papercuts
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch
Review of attachment 8607179 [details] [diff] [review]:
-----------------------------------------------------------------
Why not localize now?
Attachment #8607179 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Localized patches can't make it to 40.1, so the localization is being tracked in the bug mentioned, if we decide to localize it (some discussions on what we need to localize from last meeting)
Assignee | ||
Comment 5•9 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify+
Comment 7•9 years ago
|
||
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch
Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8607179 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
status-firefox40:
--- → fixed
Comment 9•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 10•9 years ago
|
||
Comment on attachment 8607179 [details] [diff] [review]
1164593-import-change.patch
Change approved to skip one train as part of the spring campaign.
Attachment #8607179 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x46) and Mac OS X 10.9.5.
The save profile prompt dialog has the title "Save recording..." while the import profile prompt dialog shows "Import recording..." as a title.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•