Closed
Bug 1165306
Opened 10 years ago
Closed 10 years ago
Clean up ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8606267 [details] [diff] [review]
patch
Review of attachment 8606267 [details] [diff] [review]:
-----------------------------------------------------------------
Looks straightforward. Thanks for the cleanup!
::: browser/components/nsBrowserGlue.js
@@ +2391,5 @@
> var mainAction = popupNotificationActions.length ?
> popupNotificationActions[0] : null;
> var secondaryActions = popupNotificationActions.splice(1);
>
> + // Only allow exactly one permission request here.
nit: There's the same typo in the "prompt" function, you may fix it while you're here.
Attachment #8606267 -
Flags: review?(paolo.mozmail) → review+
|
Assignee | |
Updated•10 years ago
|
Summary: Cleanup ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code → Clean up ContentPermissionPrompt.prototype._showPrompt by removing pointerLock-specific code
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•