Closed Bug 1165430 Opened 9 years ago Closed 9 years ago

Switch unlocalizable "Example Title" to "mozilla.org"

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Whiteboard: .?)

Attachments

(4 files)

v1
(deleted), patch
adw
: review+
Details | Diff | Splinter Review
for aurora (Mardak will land)
(deleted), patch
Details | Diff | Splinter Review
for beta (Mardak will land)
(deleted), patch
Details | Diff | Splinter Review
Verified screenshot
(deleted), image/png
Details
Bug 1138818 landed with an unlocalizable example title string in the onboarding. We can avoid this by using a url: mozilla.org.
Attached patch v1 (deleted) — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8607232 - Flags: review?(adw)
Iteration: --- → 41.1 - May 25
Points: --- → 1
Blocks: 1145418
Attachment #8607232 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/1f2a768c819b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
We'll uplift this so that the string doesn't change from 39 to 40.
Blocks: 1140185
No longer blocks: 1145418
Attached patch for aurora (Mardak will land) (deleted) — — Splinter Review
Attached patch for beta (Mardak will land) (deleted) — — Splinter Review
verified on Nightly - 41.0a1 (2015-05-26): Steps to verify: 1. Opened up new Firefox profile using ProfileSwitcher 2. Firefox Nightly First Run Page appears 3. Opened up new tab by clicking on the "+" 4. Onboarding tutorial overlay appears over the tiles 5. The 1st and 2nd onboarding slide has correct tile title "mozilla.org" Screenshot attached.
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
Flags: qe-verify+
Attached image Verified screenshot (deleted) —
Attachment #8610909 - Flags: review+
Flags: qe-verify+
Attachment #8610909 - Flags: review+
Comment on attachment 8610027 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610027 - Flags: approval-mozilla-aurora?
Comment on attachment 8610027 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610027 - Flags: approval-mozilla-aurora?
Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora, build ID: 20150528004000.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: