Alice0775 White Reporter
	Description • 9 years ago

[Tracking Requested - why for this release]:

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/2f6ea66057fe
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 ID:20150517030204

This happens on Windows7 Classic Style.
This happens if Titlebar disabled and not maximized window.

STR
1. Switch to Dev theme if not


Actual Results:
Menu text is almost invisible.
   (Black text and Dark blue background)

Toolbutton is not invert color in NavBar and MenuBar
   (Black button image and Dark blue background)

Expected Results:
The browser UI should be readable

	ivycarp
	Comment 1 • 9 years ago

I can confirm this:

Build: https://hg.mozilla.org/releases/mozilla-aurora/rev/24460b808b17
ID: 20150517004004

Firefox 32-bit, on Win7 x64 with classic style and no aero - multiprocess not enabled.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 2 • 9 years ago

Tracking for firefox41 given the negative user experience of unreadable browser menu.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 3 • 9 years ago

Gijs, would you be able to help me find an owner for this bug? There hasn't been any activity on this once since ~2 months. Thanks!

	:Gijs (he/him)
	Comment 4 • 9 years ago

Brian, do you have cycles to look at this?

	Brian Grinstead [:bgrins] Assignee
	Comment 5 • 9 years ago

screenshot of the problem on the light theme

	Brian Grinstead [:bgrins] Assignee
	Comment 6 • 9 years ago

It's inheriting `color: #000;` that's being set on the main window due to the lightweight theme: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/LightweightThemeConsumer.jsm#121.  For normal lightweight themes it doesn't matter because the theme's accentcolor is the background on which the menu is printed.

	Brian Grinstead [:bgrins] Assignee
	Comment 7 • 9 years ago

Had to copy in some styles from browser.css, but remove the not(:-moz-lwtheme) from it.  Not sure if there is a better way to deal with stuff like this.  Relevant styles: https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#122-137

	Brian Grinstead [:bgrins] Assignee
	Comment 8 • 9 years ago

screenshot with patch applied

	:Gijs (he/him)
	Comment 9 • 9 years ago

Comment on attachment 8632269 [details] [diff] [review]
win7-classic-deved-menu.patch

Review of attachment 8632269 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.

You may want to add a note to the original CSS asking people to update this CSS as well if they change anything.

	Brian Grinstead [:bgrins] Assignee
	Comment 10 • 9 years ago

remote:   https://hg.mozilla.org/integration/fx-team/rev/bcd122bc666a

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 11 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/bcd122bc666a

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 12 • 9 years ago

Comment on attachment 8632269 [details] [diff] [review]
win7-classic-deved-menu.patch

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]:  Almost invisible text and toolbutton on Windows7 Classic and wrong colors in DevEdition Win 10 (since bug 1172716 depends on this patch)
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: Wrong colors
[String/UUID change made/needed]: n/a

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 13 • 9 years ago

Comment on attachment 8632269 [details] [diff] [review]
win7-classic-deved-menu.patch

Approved as it's a patch with a very low risk associated and it's been in m-c for a few days.

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/85cd0bf009c6

	Cornel Ionce [:noni] [Hubs QA]
	Comment 15 • 9 years ago

Confirming this fix using the STR from the description using:
- latest Nightly, build ID: 20150722030205;
- latest Aurora, build ID: 20150722004007.