Closed
Bug 1165844
Opened 10 years ago
Closed 10 years ago
Add stopDhcp function to nsINetworkService
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
2.2 S13 (29may)
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: hchang, Assigned: hchang)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Since Bug 1165776 will run dhcp_request library call in a separate thread, 'stopDhcp' becomes able to interrupt pending dhcp request. This bug is to add
'stopDhcp' function to nsINetworkService.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → hchang
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8606955 -
Flags: review?(vchang)
Comment 2•10 years ago
|
||
Comment on attachment 8606955 [details] [diff] [review]
Bug1165844.patch
Review of attachment 8606955 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thank you.
Please open a bug to refactor wifinetutil.jsm
Attachment #8606955 -
Flags: review?(vchang) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Vincent Chang[:vchang] from comment #2)
> Comment on attachment 8606955 [details] [diff] [review]
> Bug1165844.patch
>
> Review of attachment 8606955 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Looks good, thank you.
> Please open a bug to refactor wifinetutil.jsm
Thanks for the review. I've already filed a bug to track the refactoring.
Thanks!
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8606955 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S13 (29may)
You need to log in
before you can comment on or make changes to this bug.
Description
•