Closed
Bug 1165994
Opened 10 years ago
Closed 9 years ago
Move marker tests to toolkit/devtools/server/tests
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 affected, firefox43 fixed)
RESOLVED
FIXED
Firefox 43
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
We should test these from the timeline actor, not from the front. Bonus points if they are easily copy/pastable for new markers
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Moved e10s process communication into a helper file so it can be shared on both browser/ and toolkit/ tests, and moved marker tests to toolkit/*
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0ddc12373e5
Attachment #8649963 -
Flags: review?(vporof)
Comment 2•9 years ago
|
||
Comment on attachment 8649963 [details] [diff] [review]
1165994-marker-tests.patch
Review of attachment 8649963 [details] [diff] [review]:
-----------------------------------------------------------------
Please maintain history. Use hg move to move files, qrefresh, then apply any changes on top if necessary.
I know you hate hg. I'm not doing this to make you love it.
Attachment #8649963 -
Flags: review?(vporof)
Assignee | ||
Comment 3•9 years ago
|
||
Most of the marker tests are completely different (and more consistent now) -- but the moves are much more cleaner now
Attachment #8649963 -
Attachment is obsolete: true
Attachment #8650555 -
Flags: review?(vporof)
Assignee | ||
Comment 4•9 years ago
|
||
Also some intermittent's on markers have negative time values (both start and end) -- this seems like it makes sense, and we just filter them out, so maybe we should get rid of that assertion?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0ddc12373e5
toolkit/devtools/server/tests/browser/browser_markers-gc.js | All markers have a start time between the valid range.
Updated•9 years ago
|
Attachment #8650555 -
Flags: review?(vporof) → review+
Comment 6•9 years ago
|
||
Backed out for M-e10s(dt2) failure on Linux:
https://hg.mozilla.org/integration/fx-team/rev/19c7a4a7cefe
Assignee | ||
Comment 7•9 years ago
|
||
Issue with browser.ini, didn't maintain the skipping on linux (always forget the directives are below the lines they apply to), fixed up
Comment 9•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•