Closed Bug 1166172 Opened 9 years ago Closed 9 years ago

Send MozContentEvent to gecko after the `system-first-paint` event is received.

Categories

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

Attachments

(2 files)

      No description provided.
Blocks: 1165134
The CI result: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=53fada9d870f094d9943183ff811930db71d1255
Summary: Send content event to gecko after the `system-first-paint` event is received. → Send MozContentEvent to gecko after the `system-first-paint` event is received.
Because of Bug 1167465, we need to do this work around[1] here.

[1]: https://github.com/mozilla-b2g/gaia/pull/30120
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

Hi Alive and Dominic,

Because of Bug 1167465, we need to do this work around[1] here,
or the bug will block our works.

[1]: https://github.com/mozilla-b2g/gaia/pull/30120
Attachment #8607382 - Flags: review?(alive)
Attachment #8607382 - Flags: review?(dkuo)
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

My only question is what if you missing the first-paint event because you are lazily loaded...?
Flags: needinfo?(evanxd)
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

r+ if this fixes the problem but would like to see followup to address the missing event.
Attachment #8607382 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> My only question is what if you missing the first-paint event because you
> are lazily loaded...?

This can't possibly right. We can't land a patch with this behavior.
Blocks: 1113086
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

Evan,

As we discussed offline, "system-first-paint" event looks a workable but probably not a suitable timing, I think there is a reason to explain why it works but the other events, let's investigate this together after you got back.
Attachment #8607382 - Flags: review?(dkuo)
Discussed with Alive and Dominic in person.We could try to use "Broadcast Channel API" to get the String list of System's audio channels. Let's try that!
Depends on: 1167465
Flags: needinfo?(evanxd)
The documentations of Broadcast Channel API:

https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API
Broadcast Channel API cannot work for this situation. Then I'll try Fabrice's suggestion[1].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1165134#c9
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30606
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/pull/30606
Attachment #8607382 - Attachment filename: Github pull request #30120 → Github pull request #30606
Comment on attachment 8607382 [details]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30606
Attached file Same patch, just with more comments. (deleted) —
If the CI[1] for pr[2] is good, just land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=03ec48f6bae180c567577cd6a79b22c2adc002be
[2]: https://github.com/mozilla-b2g/gaia/pull/30606
master: https://github.com/mozilla-b2g/gaia/commit/668361bff1694487b33580db1377a1df115d82ee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: