Junior [inactive] Assignee
	Description • 9 years ago

STR:
1. Let the server socket be closed non-manually
2. init the tcp presentation server again and create a device

Expected result:
create successfully

Actual result:
throws an exception

	Junior [inactive] Assignee
	Comment 1 • 9 years ago

Hello Honza,
I got trouble in |nsServerSocket|.
In a _xpcshell_ test, I'd like to simulate a server socket is dead by non-manually closed such as network down.
In other words, |aServerSocketListener.onStopListening| is called _not_ by |aServerSocket.close|.

Any ideas?
Thanks.

	Junior [inactive] Assignee
	Comment 2 • 9 years ago

WIP

init |_devices| correctly and remove the redundant |TCPPresentationServer.close|

Todo: to figure out a way to close server sockets non-manually

	Honza Bambas (:mayhemer)
	Comment 3 • 9 years ago

(In reply to Junior [:junior] from comment #1)
> Hello Honza,
> I got trouble in |nsServerSocket|.
> In a _xpcshell_ test, I'd like to simulate a server socket is dead by
> non-manually closed such as network down.
> In other words, |aServerSocketListener.onStopListening| is called _not_ by
> |aServerSocket.close|.
> 
> Any ideas?
> Thanks.

Not by hand.  I'm also not sure what you are trying to achieve.  I presume gracefully closing the socket (after which you get RST when trying to connect) is not what you want, right?

You could try up/down all interfaces the server is bound to, but this is not a question for me, rather ask some test harness folks.

	Honza Bambas (:mayhemer)
	Comment 4 • 9 years ago

BTW, google is probably your friend here ;)

	Junior [inactive] Assignee
	Comment 5 • 9 years ago

We found |aServerSocketListener.onStopListening| is called after netd says hello to b2g in booting up. Some problems occur for this case. So yes, I'd like to _not_ gracefully closing server socket.

Originally I guess there's some trick for doing this. For example, give a hint of offline as bug 1134596. I'll look around those possible tricks and try them later.

	Junior [inactive] Assignee
	Comment 6 • 9 years ago

make |_devices| init appropriately
also remove the redundant |TCPPresentationServer.close|

	Junior [inactive] Assignee
	Comment 7 • 9 years ago

try result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b684522bf317

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f66a1197daa7

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f66a1197daa7

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f66a1197daa7