Closed
Bug 1166601
Opened 10 years ago
Closed 8 years ago
Give remote-troubleshooting permissions to self-repair.mozilla.org
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: glind, Assigned: glind)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
MattN
:
review+
benjamin
:
review-
|
Details | Diff | Splinter Review |
Motivation: Heartbeat surveys need explanatory covariates to explain user scores. The Remote-troubleshooting permission give a small, constrained set to variables to analyze.
Claims:
- these variables are low risk for identity compromise
- these variables allow some useful analysis
- this api is sufficient
(Work on consuming this at the server is: https://github.com/mozilla/self-repair-server/issues/117)
Assignee | ||
Comment 1•10 years ago
|
||
Summary: Give remote-troubleshooting permissions to self.repair.mozilla.com → Give remote-troubleshooting permissions to self-repair.mozilla.org
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → glind
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
Comment on attachment 8607928 [details] [diff] [review]
Give remote-troubleshooting permissions to self-repair.mozilla.org
Review of attachment 8607928 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/app/permissions
@@ +18,5 @@
>
> # Remote troubleshooting
> host remote-troubleshooting 1 input.mozilla.org
> host remote-troubleshooting 1 support.mozilla.org
> +host remote-troubleshooting 1 self-repair.mozilla.org
Nit: indentation is off but otherwise this is all that's needed from the code side IIRC.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8608170 -
Flags: review?(MattN+bmo)
Assignee | ||
Updated•10 years ago
|
Attachment #8607928 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8608170 [details] [diff] [review]
v2 Give remote-troubleshooting permissions to self-repair.mozilla.org
Review of attachment 8608170 [details] [diff] [review]:
-----------------------------------------------------------------
(I have no idea if this needs tests, or what to do in that case)
Attachment #8608170 -
Flags: review?(benjamin)
Comment 6•10 years ago
|
||
Comment on attachment 8608170 [details] [diff] [review]
v2 Give remote-troubleshooting permissions to self-repair.mozilla.org
Review of attachment 8608170 [details] [diff] [review]:
-----------------------------------------------------------------
r=me on the technical side. I don't see any test that needs updating for this.
r?bsmedberg on the privacy aspect.
Attachment #8608170 -
Flags: review?(MattN+bmo) → review+
Comment 7•10 years ago
|
||
I don't want to approve this particular bug without seeing the broader engineering/UX plan. In particular, would the UI change, and is the data collection here already controlled by the FHR checkbox in prefs?
Flags: needinfo?(glind)
Updated•9 years ago
|
Attachment #8608170 -
Flags: review?(benjamin) → review-
Assignee | ||
Comment 8•9 years ago
|
||
reopening this, cc-ing rweiss, Osmose.
Deciding exactly what data the SHIELD service needs to see needs designing.
Claim: remote troubleshooting's set is a good first step.
Flags: needinfo?(glind)
Assignee | ||
Comment 9•8 years ago
|
||
Closing, because I think the self-repair system addon will not need this.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mkelly)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•