The titlebar on Windows 10 is now fully light gray, darkening the icons would increase the contrast, and would as well improve consistency with other apps, which have a dark icon style.

Using the Yosemite icon color is a good idea, since Yosemite apps have a very similar icon style to Windows apps (thin lines, black color). Philipp, thoughts

(In reply to Tim Nguyen [:ntim] (limited availability) from comment #1) > Using the Yosemite icon color is a good idea, since Yosemite apps have a > very similar icon style to Windows apps (thin lines, black color). > > Philipp, thoughts thoughts ?*

Adding Stephen who is currently working on the theme. We should really make a decision on that before sending Ben off to scale all the icons.

I've noticed this too. Kinda tough on the eyes because it's low-contrast. Spartan's icons are indeed a bit darker (#616161 vs our #797c80), but I suspect it's effectively a bit worse because their icons are just outlines, whereas ours are solid.

We're currently using the Toolbar.png designed for Windows 8, and that one is lighter than all other variants.

We are still working out the final design, but it will definitely be darker.

needinfo for the final images

Comment on attachment 8626644 [details] [diff] [review] Patch >+% override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-XP.png os=WINNT osversion<6 > % override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6 > % override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-aero.png os=WINNT osversion=6.1 >-% override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-XP.png os=WINNT osversion<6 >+% override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-win8.png os=WINNT osversion=6.2 >+% override chrome://browser/skin/Toolbar.png chrome://browser/skin/Toolbar-win8.png os=WINNT osversion=6.3 These were sorted by file name. Sorting by version is fine by me too. > % override chrome://browser/skin/loop/toolbar.png chrome://browser/skin/loop/toolbar-aero.png os=WINNT osversion=6 > % override chrome://browser/skin/loop/toolbar.png chrome://browser/skin/loop/toolbar-aero.png os=WINNT osversion=6.1 > % override chrome://browser/skin/loop/toolbar.png chrome://browser/skin/loop/toolbar-XP.png os=WINNT osversion<6 > % override chrome://browser/skin/loop/toolbar@2x.png chrome://browser/skin/loop/toolbar-aero@2x.png os=WINNT osversion=6 > % override chrome://browser/skin/loop/toolbar@2x.png chrome://browser/skin/loop/toolbar-aero@2x.png os=WINNT osversion=6.1 > % override chrome://browser/skin/loop/toolbar@2x.png chrome://browser/skin/loop/toolbar-XP@2x.png os=WINNT osversion<6 ... but then you should make the same change here.

[Tracking Requested - why for this release]: We should track this as Firefox 40 will be the first release with better Windows 10 design and the darker graphics are a large part of it. I will request uplift for this patch when bug 1178307 is fixed and can be uplifted as well.

Verified fixed on Nightly 42.0a1 (2015-06-30) and Aurora 41.0a2 (2015-07-06), using Windows 10 Pro x64 (Insider Preview Build 10158). The buttons from the toolbar are now darker, with the exception of the Hello button, which will be treated in Bug 1178307.

Tracking for 40 because affected, awaiting potential uplift.

Jared, could you fill the uplift requests for bug 1178307 and this one ? (so that we are ready when the second lands).

Approval Request Comment [Feature/regressing bug #]: Windows 10 icons [User impact if declined]: Windows 10 will have toolbar icons that don't have enough contrast [Describe test coverage new/current, TreeHerder]: simple icon replacement [Risks and why]: none [String/UUID change made/needed]: none

Approval Request Comment [Feature/regressing bug #]: Windows 10 icons [User impact if declined]: Windows 10 will have toolbar icons that don't have enough contrast [Describe test coverage new/current, TreeHerder]: simple icon replacement [Risks and why]: none [String/UUID change made/needed]: none

Comment on attachment 8634236 [details] [diff] [review] Patch for Beta40 We want a great version of fx for windows 10, taking it.

Verified as fixed on Firefox 40 beta 6, build ID: 20150720220238 using the latest build of Windows 10 64bit.