Closed
Bug 1167054
Opened 10 years ago
Closed 8 years ago
NetworkManager: unregisterNetworkInterface should clear active network
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: swu, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Filed for bug 1167049 comment 2.
|
Reporter | |
Comment 1•10 years ago
|
||
If an active network gets unrgistered, we should remove it from the active network. This may happen if the network has not been disconnected first.
Edgar, may I have your feedback on this?
Assignee: nobody → swu
Attachment #8609186 -
Flags: feedback?(echen)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8609186 [details] [diff] [review]
Patch: clear active network when been unregistered
Review of attachment 8609186 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/NetworkManager.js
@@ +467,5 @@
> Cr.NS_ERROR_INVALID_ARG);
> }
>
> + if (this.active == network) {
> + this.active = null;
When a network report DISCONNECTED, NetworkManager will do some clean-up for it, e.g. removing routing, dns, networkLink ... etc. IMHO, when a network do unregister without reporting DISCONNECTED first, we probably need to do same thing for it, otherwise device may stay in an unsynced situation. And also choose another network as active if any.
Attachment #8609186 -
Flags: feedback?(echen)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Got it, thanks for the feedback.
|
|
Reporter | |
Comment 4•9 years ago
|
||
Unassign myself, as I am not able to work on this in short term.
Assignee: swu → nobody
|
|
Reporter | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•