Closed
Bug 1167166
Opened 9 years ago
Closed 9 years ago
about:telemetry: "Week" and "Ping" are not localizable when displaying archived pings
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox40 | --- | unaffected |
firefox41 | --- | fixed |
People
(Reporter: flod, Assigned: gfritzsche)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rvitillo
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/file/faeecf37a482/toolkit/content/aboutTelemetry.xhtml#l70 In Telemetry Data, "Week" and "Ping" are hard-coded when switching to Archived pings.
Assignee | ||
Comment 1•9 years ago
|
||
Thanks for the heads-up Francesco.
Attachment #8608666 -
Flags: review?(rvitillo)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gfritzsche
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Whiteboard: [uplift]
Updated•9 years ago
|
Attachment #8608666 -
Flags: review?(rvitillo) → review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/30e3f33e3255
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8608666 [details] [diff] [review] 'Week' and 'Ping' are not localizable in about:telemetry when displaying archived pings Approval Request Comment [Feature/regressing bug #]: Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2. [User impact if declined]: Data & measurement insight projects delayed or blocked with direct impact on projects depending on this. [Describe test coverage new/current, TreeHerder]: We have good automation coverage of the feature. We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here. [Risks and why]: Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports. We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements. [String/UUID change made/needed]: The only string changes were to the about:telemetry page. We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.
Attachment #8608666 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #4) > [String/UUID change made/needed]: > The only string changes were to the about:telemetry page. > We decided that we can live with missing translations on that page for a > cycle as that page is not exactly user-facing. While I'm not completely sure why this can't ride the trains (but that's up to release drivers to decide), for Aurora you should do a patch that doesn't touch aboutTelemetry.dtd and hard-code the string in the XHTML file to avoid creating unnecessary noise in string frozen branches.
Assignee | ||
Comment 6•9 years ago
|
||
Ah, thanks, i didn't know - will fix that.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5) > While I'm not completely sure why this can't ride the trains FWIW: * Unified Telemetry blocks other works and we are shooting for Fx40 * the about:telemetry changes enable inspecting/QAing/... the new Telemetry data
Assignee | ||
Updated•9 years ago
|
Attachment #8608666 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Whiteboard: [uplift]
Assignee | ||
Updated•9 years ago
|
status-firefox40:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•