Alexandre Poirot [:ochameau] Assignee
	Description • 9 years ago

Bug 1161072 identified that some getOriginalLocation request were done after the tests was declared as done!
That's because many browser_computer_*.js tests are not waiting for the SelectorView instances to be done loading, especially the updateSourceLink call in its constructor, which ends up dispatching a getOriginalLocation.

We should ensure waiting for all stuff to be done with each test before proceeding to the next one!

	Alexandre Poirot [:ochameau] Assignee
	Comment 1 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=083ed2d902f6

	Alexandre Poirot [:ochameau] Assignee
	Comment 2 • 9 years ago

Comment on attachment 8608699 [details] [diff] [review]
patch

Review of attachment 8608699 [details] [diff] [review]:
-----------------------------------------------------------------

computed-view-property-expanded was fired too early, before SelectorView finished initializing and especially finished its getOriginalLocation request.

	Patrick Brosset <:pbro>
	Comment 3 • 9 years ago

Comment on attachment 8608699 [details] [diff] [review]
patch

Review of attachment 8608699 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/de2972f26a78

	Alexandre Poirot [:ochameau] Assignee
	Comment 5 • 9 years ago

This patch is not enough, browser/devtools/styleinspector/test/browser_computedview_matched-selectors_01.js still dispatch some getOriginalLocation requests on shutdown.

	Carsten Book [:Tomcat]
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/de2972f26a78

	Alexandre Poirot [:ochameau] Assignee
	Comment 7 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0965450679c4

Looks like I also need to delay the promise returned by refreshMatchedSelectors
as it is being called by test without waiting for computed-view-property-expanded event.

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/f78cdc1f29ed

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f78cdc1f29ed